Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken spacing in Form caused by nullable children #174

Merged
merged 2 commits into from
Apr 10, 2019

Conversation

suevalov
Copy link
Contributor

@suevalov suevalov commented Apr 10, 2019

Purpose of PR

  • Filter out nullable children in Form component, so the following code doesn't cause weird empty spacing:
<Form>
   {null}
  <TextField />
  <TextField />
</Form>
  • Fixed warning about incorrect usage of getDerivedStateFromProps

PR Checklist

  • I have read the relevant readme.md file(s)
  • All commits follow our Git commit message convention
  • Tests are added/updated/not required
  • Tests are passing
  • Storybook stories are added/updated/not required
  • Usage notes are added/updated/not required
  • Has been tested based on Contentful's browser support
  • Doesn't contain any sensitive information

@suevalov suevalov changed the title Fix form spacing Fix form spacing in Form caused by nullable children Apr 10, 2019
Copy link
Contributor

@wichniowski wichniowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@suevalov suevalov changed the title Fix form spacing in Form caused by nullable children Fix broken spacing in Form caused by nullable children Apr 10, 2019
@suevalov suevalov merged commit 81d5742 into master Apr 10, 2019
@suevalov suevalov deleted the fix-form-spacing branch April 10, 2019 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants