-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new property to typography components #1891
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/contentful-apps/forma-36/AUCfuKhVbe4Akxw25tMYcbhTLYFM |
Sorry, misclick 😬 My initial thought is that this kind of thing should be handled in the different components, not in the text elements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@denkristoffer yeah, that was my initial thought, but I noticed that we already has to handle it in a couple of places in cards, I assume we might have the same issue in Note, and maybe more. Maybe in that case extending the API of typography might be a good idea. |
Introducing new prop to typography components to manage cases like this one:
WDYT?