Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new property to typography components #1891

Merged
merged 4 commits into from
Feb 22, 2022
Merged

Conversation

burakukula
Copy link
Contributor

Introducing new prop to typography components to manage cases like this one:

card-overflow2

WDYT?

@vercel
Copy link

vercel bot commented Feb 16, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/contentful-apps/forma-36/AUCfuKhVbe4Akxw25tMYcbhTLYFM
✅ Preview: https://forma-36-git-fix-entry-card-contentful-apps.vercel.app

@burakukula burakukula changed the title Fix entry card feat: new property to typography components Feb 16, 2022
@denkristoffer
Copy link
Collaborator

denkristoffer commented Feb 17, 2022

Sorry, misclick 😬

My initial thought is that this kind of thing should be handled in the different components, not in the text elements.

@denkristoffer denkristoffer reopened this Feb 17, 2022
Copy link
Contributor

@massao massao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@burakukula
Copy link
Contributor Author

Sorry, misclick 😬

My initial thought is that this kind of thing should be handled in the different components, not in the text elements.

@denkristoffer yeah, that was my initial thought, but I noticed that we already has to handle it in a couple of places in cards, I assume we might have the same issue in Note, and maybe more. Maybe in that case extending the API of typography might be a good idea.

@burakukula burakukula merged commit ed309a6 into master Feb 22, 2022
@burakukula burakukula deleted the fix-entry-card branch February 22, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants