Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close button alignment in Note component #1908

Merged
merged 2 commits into from
Mar 1, 2022
Merged

fix: close button alignment in Note component #1908

merged 2 commits into from
Mar 1, 2022

Conversation

gui-santos
Copy link
Contributor

@gui-santos gui-santos commented Feb 25, 2022 •
edited
Loading

Purpose of PR

it fixes this case:
Screenshot 2022-02-25 at 15 58 13

and this case:
155946791-1c810f8f-75a0-4fea-a277-69aee78037d9

This is what I achieved:
Screenshot 2022-02-28 at 16 59 07

PR Checklist

  • I have read the relevant readme.md file(s)
  • All commits follow our Git commit message convention
  • Tests are added/updated/not required
  • Tests are passing
  • Storybook stories are added/updated/not required
  • Usage notes are added/updated/not required
  • Has been tested based on Contentful's browser support
  • Doesn't contain any sensitive information

@changeset-bot
Copy link

changeset-bot bot commented Feb 25, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7db9357

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 25, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/contentful-apps/forma-36/3PNMMbXvFEENEL2uaLghBEgXT4FH
✅ Preview: https://forma-36-git-fix-note-close-button-contentful-apps.vercel.app

@gui-santos gui-santos marked this pull request as ready for review February 28, 2022 16:07
burakukula
burakukula approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@burakukula burakukula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@gui-santos gui-santos merged commit 3fbb84b into master Mar 1, 2022
@gui-santos gui-santos deleted the fix/note-close-button branch March 1, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burakukula burakukula burakukula approved these changes

@m10l m10l Awaiting requested review from m10l

@mshaaban0 mshaaban0 Awaiting requested review from mshaaban0 mshaaban0 is a code owner

@denkristoffer denkristoffer Awaiting requested review from denkristoffer denkristoffer is a code owner

@Lelith Lelith Awaiting requested review from Lelith Lelith is a code owner

@bgutsol bgutsol Awaiting requested review from bgutsol bgutsol was automatically assigned from contentful/team-isotopes

@thebesson thebesson Awaiting requested review from thebesson thebesson was automatically assigned from contentful/team-isotopes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gui-santos @burakukula