Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix entry card description #1930

Merged
merged 1 commit into from
Mar 7, 2022
Merged

fix: fix entry card description #1930

merged 1 commit into from
Mar 7, 2022

Conversation

burakukula
Copy link
Contributor

@burakukula burakukula commented Mar 3, 2022 •
edited by Silhoue
Loading

Fixing the issue with card description
Screenshot 2022-03-03 at 19 21 39

Fix for https://contentful.atlassian.net/browse/ZEND-1898

@vercel
Copy link

vercel bot commented Mar 3, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/contentful-apps/forma-36/2RpcyU3Ag811aWXfprGdFz1aHHb2
✅ Preview: https://forma-36-git-card-fix-contentful-apps.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2022

⚠️ No Changeset found

Latest commit: 5a0ed4d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

denkristoffer
denkristoffer reviewed Mar 4, 2022
View reviewed changes
packages/components/card/src/EntryCard/EntryCard.tsx
@@ -56,7 +56,7 @@ function EntryCardDescription({
const truncatedDescription = truncate(description, 95, {});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not working or what?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is, but the problem is actually isTruncated prop. as far as I understand they are doing the same thing, and we need to break-word to handle this case.

@burakukula burakukula merged commit 4c99709 into main Mar 7, 2022
@burakukula burakukula deleted the card-fix branch March 7, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denkristoffer denkristoffer denkristoffer approved these changes

@m10l m10l Awaiting requested review from m10l

@mshaaban0 mshaaban0 Awaiting requested review from mshaaban0

@Lelith Lelith Awaiting requested review from Lelith

@massao massao Awaiting requested review from massao massao is a code owner automatically assigned from contentful/team-isotopes

@bgutsol bgutsol Awaiting requested review from bgutsol bgutsol is a code owner automatically assigned from contentful/team-isotopes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burakukula @denkristoffer