Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement new website homepage #1949

Merged
merged 8 commits into from
Apr 11, 2022
Merged

feat: implement new website homepage #1949

merged 8 commits into from
Apr 11, 2022

Conversation

gui-santos
Copy link
Contributor

@gui-santos gui-santos commented Mar 14, 2022

Purpose of PR

Screenshot 2022-03-22 at 11 18 14

PR Checklist

  • I have read the relevant readme.md file(s)
  • All commits follow our Git commit message convention
  • Tests are added/updated/not required
  • Tests are passing
  • Storybook stories are added/updated/not required
  • Usage notes are added/updated/not required
  • Has been tested based on Contentful's browser support
  • Doesn't contain any sensitive information

@vercel
Copy link

vercel bot commented Mar 14, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/contentful-apps/forma-36/8zvg9eHmS851BjbUiDhwPAK34T4N
✅ Preview: https://forma-36-git-feat-website-homepage.colorfuldemo.com

@changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2022

⚠️ No Changeset found

Latest commit: bde1d2f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gui-santos gui-santos requested a review from domarku March 14, 2022 15:58
@burakukula
Copy link
Contributor

burakukula commented Mar 14, 2022

@domarku feedback from my side is that I would not expect those cards are links. I think we should have CTA in each card if we would like to be clear about it. Or maybe it's just me?
Something also is strange about those cards, I guess I have some sort of need for them to be the same size. but again, maybe it is just me.
Footer in gray with this white gap on the left side might be a bit confusing I think?
Code wise all good from my side.

@mshaaban0
Copy link
Collaborator

My 2 cents on this that it could use some colors, maybe icons on cards or something. It kinda look cheap 🥲

@domarku
Copy link
Contributor

domarku commented Mar 15, 2022

Alright friends, thanks for the feedback! What I'm getting is "back to the drawing board". It's not yet ready for a PR. Let me iterate on it a bit and get more of your feedback on the design before we put it up :)

@domarku
Copy link
Contributor

domarku commented Mar 25, 2022

@gui-santos let's wait for Monday to merge the homepage. I need to prepare the UI Kit for publishing today.

Copy link
Collaborator

@Lelith Lelith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the new design

@gui-santos gui-santos enabled auto-merge (squash) April 11, 2022 12:02
@gui-santos gui-santos merged commit 21253b9 into main Apr 11, 2022
@gui-santos gui-santos deleted the feat/website-homepage branch April 11, 2022 12:06
denkristoffer pushed a commit to Wake1st/forma-36 that referenced this pull request Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants