Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(icons): Add TriangleOutline and ArrowBackward icons #2000

Merged
merged 3 commits into from
Apr 20, 2022
Merged

feat(icons): Add TriangleOutline and ArrowBackward icons #2000

merged 3 commits into from
Apr 20, 2022

Conversation

damienxy
Copy link
Contributor

@damienxy damienxy commented Apr 19, 2022 •
edited
Loading

Purpose of PR

Adding two new icons to the icon library, TriangleOutline and ArrowBackward.

PR Checklist

  • I have read the relevant readme.md file(s)
  • All commits follow our Git commit message convention
  • Tests are added/updated/not required
  • Tests are passing
  • Storybook stories are added/updated/not required
  • Usage notes are added/updated/not required
  • Has been tested based on Contentful's browser support
  • Doesn't contain any sensitive information

@vercel
Copy link

vercel bot commented Apr 19, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
forma-36 ✅ Ready (Inspect) Visit Preview Apr 20, 2022 at 1:14PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Apr 19, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9dc5695

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@damienxy damienxy changed the title feat(icons): Add TriangleOutline and rrowBackward icons feat(icons): Add TriangleOutline and ArrowBackward icons Apr 19, 2022
@damienxy damienxy marked this pull request as ready for review April 20, 2022 13:05
@damienxy damienxy requested a review from domarku April 20, 2022 13:05
denkristoffer
denkristoffer approved these changes Apr 20, 2022
View reviewed changes
Copy link
Collaborator

@denkristoffer denkristoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@damienxy damienxy merged commit 70b21a6 into main Apr 20, 2022
@damienxy damienxy deleted the feat/add-triangle-and-arrow-icons branch April 20, 2022 13:20
denkristoffer added a commit to Wake1st/forma-36 that referenced this pull request Oct 5, 2022
@damienxy @denkristoffer
feat(icons): Add TriangleOutline and ArrowBackward icons (contentful#…
c990f36 
…2000)

* feat(icons): Add TriangleOutline and ArrowBackward icons

Co-authored-by: denkristoffer <denkristoffer@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denkristoffer denkristoffer denkristoffer approved these changes

@mshaaban0 mshaaban0 Awaiting requested review from mshaaban0

@Lelith Lelith Awaiting requested review from Lelith

@domarku domarku Awaiting requested review from domarku domarku is a code owner automatically assigned from contentful/team-isotopes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@damienxy @denkristoffer