Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add arrow upward icon #2079

Merged
merged 9 commits into from
Jun 9, 2022
Merged

feat: add arrow upward icon #2079

merged 9 commits into from
Jun 9, 2022

Conversation

Spring3
Copy link
Contributor

@Spring3 Spring3 commented Jun 8, 2022

Purpose of PR

PR Checklist

  • I have read the relevant readme.md file(s)
  • All commits follow our Git commit message convention
  • Tests are added/updated/not required
  • Tests are passing
  • Storybook stories are added/updated/not required
  • Usage notes are added/updated/not required
  • Has been tested based on Contentful's browser support
  • Doesn't contain any sensitive information

@changeset-bot
Copy link

changeset-bot bot commented Jun 8, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: d34ff4b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 8, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
forma-36 ✅ Ready (Inspect) Visit Preview Jun 9, 2022 at 1:04PM (UTC)

denkristoffer
denkristoffer reviewed Jun 9, 2022
View reviewed changes
Copy link
Collaborator

@denkristoffer denkristoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the build is failing because of naming issues. We also have to add the new exports to packages/components/icons/src/index.ts

packages/components/icons/src/ArrowUpward.tsx Outdated Show resolved Hide resolved
packages/components/icons/src/ArrowUpwardTrimmed.tsx Outdated Show resolved Hide resolved
Spring3 and others added 3 commits June 9, 2022 11:41
@Spring3 @denkristoffer
Update packages/components/icons/src/ArrowUpward.tsx
ad49adf 
Co-authored-by: Kristoffer <denkristoffer@users.noreply.github.com>
@Spring3 @denkristoffer
Update packages/components/icons/src/ArrowUpwardTrimmed.tsx
83bd86a 
Co-authored-by: Kristoffer <denkristoffer@users.noreply.github.com>
@Spring3
chore: add missing export
c15ab5b
@denkristoffer
Copy link
Collaborator

denkristoffer commented Jun 9, 2022 •
edited
Loading

The SVG itself looks off, are the paths correct? https://5fd1dda724cc620021ace8c5-agzeekenuo.chromatic.com/?path=%2Fstory%2Fcomponents-icons--overview

denkristoffer
denkristoffer reviewed Jun 9, 2022
View reviewed changes
packages/components/icons/src/ArrowUpwardTrimmed.tsx Outdated
</Fragment>
),
trimmed: true,
viewBox: '0 0 48 48',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the view box is the same as the "regular" icon we don't need the trimmed variant.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the "regular" icon size?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you mean the size defined by material design package. Ok, removing it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean the ArrowUpward.tsx you're adding. Trimmed is for cases where you have an icon with a view box smaller than 24x24 and you want a variant without the extra padding. I know this is not clear from the docs 🙃

@Spring3 Spring3 marked this pull request as ready for review June 9, 2022 12:03
@Spring3 Spring3 requested review from a team, mshaaban0 and Lelith as code owners June 9, 2022 12:03
denkristoffer
denkristoffer approved these changes Jun 9, 2022
View reviewed changes
Copy link
Collaborator

@denkristoffer denkristoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Spring3 Spring3 merged commit 8651b5b into main Jun 9, 2022
@Spring3 Spring3 deleted the feat/arrow-upward-icon branch June 9, 2022 13:19
denkristoffer added a commit to Wake1st/forma-36 that referenced this pull request Oct 5, 2022
@Spring3 @denkristoffer
feat: add arrow upward icon (contentful#2079)
edc0feb 
* feat: add arrow upward icon

Co-authored-by: Kristoffer <denkristoffer@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denkristoffer denkristoffer denkristoffer approved these changes

@mshaaban0 mshaaban0 Awaiting requested review from mshaaban0

@Lelith Lelith Awaiting requested review from Lelith

@thebesson thebesson Awaiting requested review from thebesson thebesson is a code owner automatically assigned from contentful/team-isotopes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Spring3 @denkristoffer