Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix ModalHeading from h1 to h2 #2098

Merged
merged 1 commit into from
Jun 22, 2022
Merged

fix: fix ModalHeading from h1 to h2 #2098

merged 1 commit into from
Jun 22, 2022

Conversation

burakukula
Copy link
Contributor

No description provided.

@burakukula burakukula requested review from a team, mshaaban0 and Lelith as code owners June 22, 2022 10:15
@changeset-bot
Copy link

changeset-bot bot commented Jun 22, 2022

⚠️ No Changeset found

Latest commit: 90cfede

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 22, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
forma-36 ✅ Ready (Inspect) Visit Preview Jun 22, 2022 at 10:22AM (UTC)

Lelith
Lelith approved these changes Jun 22, 2022
View reviewed changes
Copy link
Collaborator

@Lelith Lelith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@burakukula burakukula merged commit 5ab7d2c into main Jun 22, 2022
@burakukula burakukula deleted the fix-modal-heading branch June 22, 2022 10:40
denkristoffer pushed a commit to Wake1st/forma-36 that referenced this pull request Oct 5, 2022
@burakukula @denkristoffer
fix: fix ModalHeading from h1 to h2 (contentful#2098)
bdf8cef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lelith Lelith Lelith approved these changes

@mshaaban0 mshaaban0 Awaiting requested review from mshaaban0

@massao massao Awaiting requested review from massao massao is a code owner automatically assigned from contentful/team-isotopes

@thebesson thebesson Awaiting requested review from thebesson thebesson is a code owner automatically assigned from contentful/team-isotopes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@burakukula @Lelith