Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(f36-codemod): ESM #2264

Merged
merged 2 commits into from
Apr 9, 2024
Merged

feat(f36-codemod): ESM #2264

merged 2 commits into from
Apr 9, 2024

Conversation

denkristoffer
Copy link
Collaborator

Purpose of PR

ESM codemod to unblock package upgrades.

@vercel
Copy link

vercel bot commented Oct 4, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Apr 9, 2024 0:53am

@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 53d087b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@contentful/f36-codemod Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link

github-actions bot commented Oct 4, 2022 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 130.53 KB (0%) 2.7 s (0%) 233 ms (-24.89% 🔽) 2.9 s
Module 127.46 KB (0%) 2.6 s (0%) 280 ms (-24.76% 🔽) 2.9 s

@denkristoffer denkristoffer mentioned this pull request Oct 17, 2022
Closed
@denkristoffer denkristoffer marked this pull request as ready for review October 17, 2022 16:20
@denkristoffer denkristoffer requested review from a team, Lelith and fabe as code owners October 17, 2022 16:20
@denkristoffer
Copy link
Collaborator Author

I tried this out locally and it seemed to work fine even with node 14. @massao are there any gotchas or specific situations you think I should test before merging?

@massao
Copy link
Contributor

massao commented Oct 24, 2022 •
edited
Loading

I tried this out locally and it seemed to work fine even with node 14. @massao are there any gotchas or specific situations you think I should test before merging?

maybe just running it against some other repos?? also test that it works with the arguments and with the wizard, other than that, I think it should be fine if it's working locally

@massao
Copy link
Contributor

massao commented Oct 24, 2022

btw, should we mark this as a major change on the codemod?

@denkristoffer
Copy link
Collaborator Author

I ran the wizard on a part of our web app. Will try out with arguments.

@denkristoffer denkristoffer mentioned this pull request Oct 24, 2022
Closed
@github-actions
Copy link

Marking pull request as stale since there was no activity for 30 days

@github-actions github-actions bot added the stale Used to mark when there was no activity for a set period of time label Nov 24, 2022
@denkristoffer denkristoffer mentioned this pull request Jul 11, 2023
Closed
@github-actions github-actions bot removed the stale Used to mark when there was no activity for a set period of time label Jan 18, 2024
@github-actions GitHub Actions
Copy link

Marking pull request as stale since there was no activity for 30 days

@github-actions github-actions bot added the stale Used to mark when there was no activity for a set period of time label Feb 17, 2024
@denkristoffer denkristoffer removed the stale Used to mark when there was no activity for a set period of time label Apr 9, 2024
@denkristoffer denkristoffer merged commit 9f63a40 into main Apr 9, 2024
12 checks passed
@denkristoffer denkristoffer deleted the feat/esm-codemod branch April 9, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@massao massao massao approved these changes

@Lelith Lelith Awaiting requested review from Lelith

@fabe fabe Awaiting requested review from fabe

@mshaaban0 mshaaban0 Awaiting requested review from mshaaban0 mshaaban0 is a code owner automatically assigned from contentful/team-isotopes

@bgutsol bgutsol Awaiting requested review from bgutsol bgutsol is a code owner automatically assigned from contentful/team-isotopes

@cf-remylenoir cf-remylenoir Awaiting requested review from cf-remylenoir

@damann damann Awaiting requested review from damann damann is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@denkristoffer @massao