Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(menu): Safari issue on closing menu clicking on trigger #2338

Merged
merged 7 commits into from
Nov 24, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(popover): apply fix on popover component
  • Loading branch information
massao committed Nov 24, 2022
commit 7570f544854a5fafb5a41d1c5a37f4ec57093b8b
26 changes: 23 additions & 3 deletions packages/components/popover/src/Popover.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
import React, { useMemo, useState, useEffect, useCallback } from 'react';
import React, {
useMemo,
useState,
useEffect,
useCallback,
useRef,
} from 'react';
import { useId, mergeRefs, type ExpandProps } from '@contentful/f36-core';
import type { Placement, Modifier } from '@popperjs/core';
import { PopoverContextProvider, PopoverContextType } from './PopoverContext';
Expand Down Expand Up @@ -186,12 +192,25 @@ export function Popover(props: ExpandProps<PopoverProps>) {
setTimeout(() => triggerElement?.focus({ preventScroll: true }), 0);
}, [onClose, triggerElement]);

// Safari has an issue with the relatedTarget that we use on the onBlur for getPopoverProps,
// which was causing the popover to close and reopen when clicking on the trigger.
// We will use the isMouseDown to prevent triggering blur in the cases where the user clicks on the trigger.
const isMouseDown = useRef<Boolean>(false);

const contextValue: PopoverContextType = useMemo(
() => ({
isOpen: Boolean(isOpen),
usePortal,
renderOnlyWhenOpen,
getTriggerProps: (_ref = null) => ({
getTriggerProps: (_props = {}, _ref = null) => ({
onMouseDown: (event) => {
isMouseDown.current = true;
_props.onMouseDown?.(event);
},
onMouseUp: (event) => {
isMouseDown.current = false;
_props.onMouseUp?.(event);
},
ref: mergeRefs(setTriggerElement, _ref),
['aria-expanded']: Boolean(isOpen),
['aria-controls']: popoverId,
Expand Down Expand Up @@ -220,7 +239,8 @@ export function Popover(props: ExpandProps<PopoverProps>) {
popoverElement?.contains(relatedTarget);
const targetIsTrigger =
triggerElement === relatedTarget ||
triggerElement?.contains(relatedTarget);
triggerElement?.contains(relatedTarget) ||
isMouseDown.current;

if (targetIsPopover || targetIsTrigger) {
return;
Expand Down
5 changes: 4 additions & 1 deletion packages/components/popover/src/PopoverContext.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,10 @@ export type PopoverContextType = {
_props: HTMLProps<HTMLDivElement>,
_ref: React.Ref<HTMLDivElement>,
) => HTMLProps<HTMLDivElement>;
getTriggerProps: (_ref: React.Ref<HTMLElement>) => HTMLProps<HTMLElement>;
getTriggerProps: (
_props: HTMLProps<HTMLElement>,
_ref: React.Ref<HTMLElement>,
) => HTMLProps<HTMLElement>;
};

const PopoverContext = React.createContext<PopoverContextType | undefined>(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export const PopoverTrigger = (props: PopoverTriggerProps) => {
const { getTriggerProps } = usePopoverContext();

return React.cloneElement(child, {
...getTriggerProps(child.ref),
...getTriggerProps(child.props, child.ref),
'aria-haspopup': child.props['aria-haspopup'] ?? 'dialog',
});
};