Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): normalise letter spacing and text transform on tooltip #2373

Merged
merged 2 commits into from
Jan 11, 2023

Conversation

massao
Copy link
Contributor

@massao massao commented Jan 10, 2023

Purpose of PR

Set textTransform and letterSpacing to initial value on the Tooltip, to avoid it inheriting the style from parent.

Before
image

After
image

@massao massao requested review from a team and Lelith as code owners January 10, 2023 16:19
@vercel
Copy link

vercel bot commented Jan 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
forma-36 ✅ Ready (Inspect) Visit Preview Jan 10, 2023 at 4:28PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Jan 10, 2023

🦋 Changeset detected

Latest commit: fab645d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
@contentful/f36-tooltip Patch
@contentful/f36-accordion Patch
@contentful/f36-asset Patch
@contentful/f36-autocomplete Patch
@contentful/f36-badge Patch
@contentful/f36-button Patch
@contentful/f36-card Patch
@contentful/f36-collapse Patch
@contentful/f36-copybutton Patch
@contentful/f36-core Patch
@contentful/f36-datetime Patch
@contentful/f36-datepicker Patch
@contentful/f36-drag-handle Patch
@contentful/f36-entity-list Patch
@contentful/f36-forms Patch
@contentful/f36-icon Patch
@contentful/f36-list Patch
@contentful/f36-menu Patch
@contentful/f36-modal Patch
@contentful/f36-note Patch
@contentful/f36-notification Patch
@contentful/f36-pagination Patch
@contentful/f36-pill Patch
@contentful/f36-popover Patch
@contentful/f36-skeleton Patch
@contentful/f36-spinner Patch
@contentful/f36-table Patch
@contentful/f36-tabs Patch
@contentful/f36-text-link Patch
@contentful/f36-typography Patch
@contentful/f36-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link

github-actions bot commented Jan 10, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 122.9 KB (+0.01% 🔺) 2.5 s (+0.01% 🔺) 376 ms (+73.64% 🔺) 2.9 s
Module 119.53 KB (+0.01% 🔺) 2.4 s (+0.01% 🔺) 221 ms (+24.31% 🔺) 2.7 s

@massao massao merged commit 789f46a into main Jan 11, 2023
@massao massao deleted the fix/CFCX-96 branch January 11, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants