-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(entity-status-badge): add isScheduled prop #2486
Conversation
🦋 Changeset detectedLatest commit: 7b626a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f716eb8
to
211e89c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/components/badge/src/EntityStatusBadge/EntityStatusBadge.tsx
Outdated
Show resolved
Hide resolved
packages/components/badge/src/EntityStatusBadge/EntityStatusBadge.tsx
Outdated
Show resolved
Hide resolved
@bgutsol I updated the docs. Now that I look at it I don't think it makes sense to have content guidelines or accessibility guidelines for this component since neither the content nor the styling can be customised. |
Purpose of PR
Add a prop to
EntityStatusBadge
that lets us mark entities as having a scheduled action. This will make the badge render ourClockIcon
.