Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(entity-status-badge): add isScheduled prop #2486

Merged
merged 3 commits into from
May 24, 2023

Conversation

denkristoffer
Copy link
Collaborator

Purpose of PR

Add a prop to EntityStatusBadge that lets us mark entities as having a scheduled action. This will make the badge render our ClockIcon.

@denkristoffer denkristoffer requested review from a team and Lelith as code owners May 24, 2023 08:59
@changeset-bot
Copy link

changeset-bot bot commented May 24, 2023

🦋 Changeset detected

Latest commit: 7b626a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@contentful/f36-badge Patch
@contentful/f36-accordion Patch
@contentful/f36-asset Patch
@contentful/f36-autocomplete Patch
@contentful/f36-button Patch
@contentful/f36-card Patch
@contentful/f36-collapse Patch
@contentful/f36-copybutton Patch
@contentful/f36-core Patch
@contentful/f36-datetime Patch
@contentful/f36-datepicker Patch
@contentful/f36-drag-handle Patch
@contentful/f36-entity-list Patch
@contentful/f36-empty-state Patch
@contentful/f36-forms Patch
@contentful/f36-icon Patch
@contentful/f36-list Patch
@contentful/f36-menu Patch
@contentful/f36-modal Patch
@contentful/f36-note Patch
@contentful/f36-notification Patch
@contentful/f36-pagination Patch
@contentful/f36-pill Patch
@contentful/f36-popover Patch
@contentful/f36-skeleton Patch
@contentful/f36-spinner Patch
@contentful/f36-table Patch
@contentful/f36-tabs Patch
@contentful/f36-text-link Patch
@contentful/f36-tooltip Patch
@contentful/f36-typography Patch
@contentful/f36-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview May 24, 2023 11:33am

@github-actions
Copy link

github-actions bot commented May 24, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 143.27 KB (+0.05% 🔺) 2.9 s (+0.05% 🔺) 451 ms (+54.4% 🔺) 3.4 s
Module 139.86 KB (+0.04% 🔺) 2.8 s (+0.04% 🔺) 341 ms (-39.14% 🔽) 3.2 s

Copy link
Contributor

@massao massao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bgutsol bgutsol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Let's add example to the website docs as well.
  2. There are some changes in the chromatic that looks like wrong ones
CleanShot 2023-05-24 at 12 58 49@2x

@denkristoffer
Copy link
Collaborator Author

2. There are some changes in the chromatic that looks like wrong ones
CleanShot 2023-05-24 at 12 58 49@2x

Thanks for flagging. It's the baseline that's wrong, I had missed setting the size for the last column of badges. The new snapshot is the right one 👍

@denkristoffer
Copy link
Collaborator Author

@bgutsol I updated the docs.

Now that I look at it I don't think it makes sense to have content guidelines or accessibility guidelines for this component since neither the content nor the styling can be customised.

@denkristoffer denkristoffer merged commit 408588b into main May 24, 2023
12 checks passed
@denkristoffer denkristoffer deleted the feat/entity-status-badge-isscheduled branch May 24, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants