Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): retain transparent button focus background #2489

Merged
merged 2 commits into from
May 24, 2023

Conversation

denkristoffer
Copy link
Collaborator

@denkristoffer denkristoffer commented May 24, 2023

Purpose of PR

The transparent button should keep the background as none when focused, only difference should be the outline. Have a look at https://forma-36-git-fix-transparent-button-hover.colorfuldemo.com/components/button#variants

image

@changeset-bot
Copy link

changeset-bot bot commented May 24, 2023

🦋 Changeset detected

Latest commit: 5fca169

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@contentful/f36-button Patch
@contentful/f36-accordion Patch
@contentful/f36-asset Patch
@contentful/f36-autocomplete Patch
@contentful/f36-badge Patch
@contentful/f36-card Patch
@contentful/f36-collapse Patch
@contentful/f36-copybutton Patch
@contentful/f36-core Patch
@contentful/f36-datetime Patch
@contentful/f36-datepicker Patch
@contentful/f36-drag-handle Patch
@contentful/f36-entity-list Patch
@contentful/f36-empty-state Patch
@contentful/f36-forms Patch
@contentful/f36-icon Patch
@contentful/f36-list Patch
@contentful/f36-menu Patch
@contentful/f36-modal Patch
@contentful/f36-note Patch
@contentful/f36-notification Patch
@contentful/f36-pagination Patch
@contentful/f36-pill Patch
@contentful/f36-popover Patch
@contentful/f36-skeleton Patch
@contentful/f36-spinner Patch
@contentful/f36-table Patch
@contentful/f36-tabs Patch
@contentful/f36-text-link Patch
@contentful/f36-tooltip Patch
@contentful/f36-typography Patch
@contentful/f36-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview May 24, 2023 2:41pm

@denkristoffer denkristoffer changed the title fix(button): keep transparent button focus background fix(button): retain transparent button focus background May 24, 2023
@github-actions
Copy link

github-actions bot commented May 24, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 143.26 KB (-0.02% 🔽) 2.9 s (-0.02% 🔽) 290 ms (-45.26% 🔽) 3.2 s
Module 139.85 KB (-0.02% 🔽) 2.8 s (-0.02% 🔽) 458 ms (+24.1% 🔺) 3.3 s

@denkristoffer denkristoffer merged commit cbef6dc into main May 24, 2023
12 checks passed
@denkristoffer denkristoffer deleted the fix/transparent-button-hover branch May 24, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants