feat(button): restyle negative variant

[denkristoffer]

Purpose of PR

Restyled the negative button variant to make it easier for users with deuteranomaly to differentiate it from the positive variant.

[changeset-bot]

🦋 Changeset detected

Latest commit: fab412f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 33 packages

Name	Type
@contentful/f36-button	Minor
@contentful/f36-forms	Minor
@contentful/f36-icon	Minor
@contentful/f36-tokens	Patch
@contentful/f36-accordion	Minor
@contentful/f36-asset	Minor
@contentful/f36-autocomplete	Minor
@contentful/f36-badge	Minor
@contentful/f36-card	Minor
@contentful/f36-collapse	Minor
@contentful/f36-copybutton	Minor
@contentful/f36-core	Minor
@contentful/f36-datetime	Minor
@contentful/f36-datepicker	Minor
@contentful/f36-drag-handle	Minor
@contentful/f36-entity-list	Minor
@contentful/f36-empty-state	Minor
@contentful/f36-list	Minor
@contentful/f36-menu	Minor
@contentful/f36-modal	Minor
@contentful/f36-note	Minor
@contentful/f36-notification	Minor
@contentful/f36-pagination	Minor
@contentful/f36-pill	Minor
@contentful/f36-popover	Minor
@contentful/f36-skeleton	Minor
@contentful/f36-spinner	Minor
@contentful/f36-table	Minor
@contentful/f36-tabs	Minor
@contentful/f36-text-link	Minor
@contentful/f36-tooltip	Minor
@contentful/f36-typography	Minor
@contentful/f36-components	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
forma-36	✅ Ready (Inspect)	Visit Preview	Jun 7, 2023 7:42am

[github-actions]

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
CommonJS	143.27 KB (-0.02% 🔽)	2.9 s (-0.02% 🔽)	121 ms (+41.61% 🔺)	3 s
Module	139.79 KB (-0.01% 🔽)	2.8 s (-0.01% 🔽)	96 ms (+41.65% 🔺)	2.9 s

[bgutsol]

I think icons should also have red color, otherwise, they are no different to secondary

[denkristoffer]

@fabe I updated icon colours here, should I change the previous uses of colorNegative to match the red600 or keep it as red500?

[fabe]

@fabe I updated icon colours here, should I change the previous uses of colorNegative to match the red600 or keep it as red500?

Which previous uses? For the Button with startIcon?

[denkristoffer]

Which previous uses? For the Button with startIcon?

@fabe Basically the invalid border and message is no longer the same as the icon here: https://www.chromatic.com/test?appId=5fd1dda724cc620021ace8c5&id=647ef510af8e957bf9146bdd

[fabe]

Which previous uses? For the Button with startIcon?

@fabe Basically the invalid border and message is no longer the same as the icon here: https://www.chromatic.com/test?appId=5fd1dda724cc620021ace8c5&id=647ef510af8e957bf9146bdd

Yep, this is OK to change as well.

[bgutsol]

should we include all the components where you've adjusted styles?

[denkristoffer]

Done.

[bgutsol]

I thought we have to list packages as well, am I wrong?

[denkristoffer]

I think it doesn't matter here since everything gets bumped anyway but I can add it.