Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add appearance icon [PHX-2643] #2534

Merged
merged 3 commits into from
Jul 17, 2023
Merged

feat: add appearance icon [PHX-2643] #2534

merged 3 commits into from
Jul 17, 2023

Conversation

marcolink
Copy link
Member

@marcolink marcolink commented Jul 14, 2023 •
edited
Loading

Purpose of PR

Add a new icon (will be used in Merge app) CircleHalf

PR Checklist

  • I have read the relevant readme.md file(s)
  • All commits follow our Git commit message convention
  • Tests are added/updated/not required
  • Tests are passing
  • Storybook stories are added/updated/not required
  • Usage notes are added/updated/not required
  • Has been tested based on Contentful's browser support
  • Doesn't contain any sensitive information

@marcolink marcolink requested review from a team and Lelith as code owners July 14, 2023 13:44
@changeset-bot
Copy link

changeset-bot bot commented Jul 14, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 8f80ae1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@contentful/f36-icons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Jul 17, 2023 0:37am

@github-actions
Copy link

github-actions bot commented Jul 14, 2023 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 148.97 KB (+0.33% 🔺) 3 s (+0.33% 🔺) 126 ms (+23.78% 🔺) 3.2 s
Module 145.23 KB (+0.33% 🔺) 3 s (+0.33% 🔺) 99 ms (-4.2% 🔽) 3.1 s

bgutsol
bgutsol reviewed Jul 17, 2023
View reviewed changes
Copy link
Contributor

@bgutsol bgutsol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor change

packages/components/icons/src/Appearance.tsx Outdated Show resolved Hide resolved
@marcolink @bgutsol
Update packages/components/icons/src/Appearance.tsx
8e435a7 
Co-authored-by: Bohdan Hutsol <bohdan.hutsol@contentful.com>
bgutsol
bgutsol reviewed Jul 17, 2023
View reviewed changes
Copy link
Contributor

@bgutsol bgutsol left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also forgot to mention that you have to generate changeset ☝️ Otherwise new version won't be published
just run npx changeset

@marcolink marcolink merged commit 9ca9200 into main Jul 17, 2023
12 checks passed
@marcolink marcolink deleted the feat/add-appearance-icon branch July 17, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgutsol bgutsol bgutsol approved these changes

@damienxy damienxy damienxy approved these changes

@fidanismiri fidanismiri fidanismiri approved these changes

@Lelith Lelith Awaiting requested review from Lelith

@giotiskl giotiskl Awaiting requested review from giotiskl giotiskl is a code owner automatically assigned from contentful/team-isotopes

@domilejanenaite domilejanenaite Awaiting requested review from domilejanenaite domilejanenaite is a code owner automatically assigned from contentful/team-isotopes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marcolink @bgutsol @damienxy @fidanismiri