fix(TextLink): vertical alignment when used within flexbox container #2584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxcheremisin
requested review from
Lelith,
cf-remylenoir,
damann and
a team
as code owners
🦋 Changeset detectedLatest commit: f48938d The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
|
Worth mentioning that I had another idea to add |
ghepting
approved these changes
Sep 28, 2023
massao
approved these changes
Sep 29, 2023
maxcheremisin
deleted the
fix/text-link-vertical-alignment-in-flexbox
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR
Fix TextLink vertical alignment when used within flexbox container.
Problem
When used within a flexbox container TextLink stretches to full height. It used to have
style="align-items: center"so when it's stretched it still would look aligned. But with recent changes in #2574 it was changed tostyle="align-items: baseline"to align it when used within inline text elements.With this PR I'd like to return previous behaviour back (when TextLink is stretched to full height, and its elements are centrally aligned), but at the same time keep text and icon aligned to baseline when used within other text.
🚨 But to make it work I had to add an extra DOM element.
Bug screenshots