Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New UMD configuration. Required correct peer React version. #26

Merged
merged 3 commits into from
Dec 4, 2018

Conversation

suevalov
Copy link
Contributor

@suevalov suevalov commented Dec 4, 2018

Few changes:

  1. Rollup produces two UMD files: dist/umd/forma-36-react-components.development.min.js and dist/umd/forma-36-react-components.production.min.js. Both of them are minified and expose global Forma36 object.

I checked it locally with React and ReactDOM being served from https://unpkg.com/ - works like charm.

  1. We use new React features internally that are available since 16.3.x (createContext), so we need to require correct peer deps.

Copy link
Contributor

@wichniowski wichniowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@suevalov suevalov merged commit bca2c7d into master Dec 4, 2018
@suevalov suevalov deleted the fix/correct-umd-build branch December 4, 2018 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants