Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: IconButton size type #2605

Merged
merged 2 commits into from
Nov 8, 2023
Merged

fix: IconButton size type #2605

merged 2 commits into from
Nov 8, 2023

Conversation

bgutsol
Copy link
Contributor

@bgutsol bgutsol commented Nov 8, 2023

  • Fix IconButton size prop marked as deprecated. Leave it only as comment for size large.

CleanShot 2023-11-08 at 15 51 40@2x

Related PR:
#2576

Copy link

changeset-bot bot commented Nov 8, 2023

🦋 Changeset detected

Latest commit: ab0318a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@contentful/f36-button Patch
@contentful/f36-accordion Patch
@contentful/f36-asset Patch
@contentful/f36-autocomplete Patch
@contentful/f36-badge Patch
@contentful/f36-card Patch
@contentful/f36-collapse Patch
@contentful/f36-copybutton Patch
@contentful/f36-core Patch
@contentful/f36-datetime Patch
@contentful/f36-datepicker Patch
@contentful/f36-drag-handle Patch
@contentful/f36-entity-list Patch
@contentful/f36-empty-state Patch
@contentful/f36-forms Patch
@contentful/f36-icon Patch
@contentful/f36-list Patch
@contentful/f36-menu Patch
@contentful/f36-modal Patch
@contentful/f36-note Patch
@contentful/f36-notification Patch
@contentful/f36-pagination Patch
@contentful/f36-pill Patch
@contentful/f36-popover Patch
@contentful/f36-skeleton Patch
@contentful/f36-spinner Patch
@contentful/f36-table Patch
@contentful/f36-tabs Patch
@contentful/f36-text-link Patch
@contentful/f36-tooltip Patch
@contentful/f36-typography Patch
@contentful/f36-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Nov 8, 2023 2:54pm

Copy link
Collaborator

@cf-remylenoir cf-remylenoir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@bgutsol bgutsol enabled auto-merge (squash) November 8, 2023 14:53
@maxcheremisin
Copy link
Member

there is a similar comment for entityType prop, wonder why it works there
image

Copy link

github-actions bot commented Nov 8, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 129.58 KB (0%) 2.6 s (0%) 97 ms (+37.41% 🔺) 2.7 s
Module 126.05 KB (0%) 2.6 s (0%) 107 ms (-38.37% 🔽) 2.7 s

@cf-remylenoir
Copy link
Collaborator

there is a similar comment for entityType prop, wonder why it works there image

My hunch is that because there is some more text after the @deprecated decorator it is not assigning it to the whole property

@bgutsol bgutsol merged commit 48a30cb into main Nov 8, 2023
12 checks passed
@bgutsol bgutsol deleted the fix-icon-btn-size-type branch November 8, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants