Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow having icons with small badge #2627

Merged
merged 4 commits into from
Dec 6, 2023
Merged

feat: allow having icons with small badge #2627

merged 4 commits into from
Dec 6, 2023

Conversation

bgutsol
Copy link
Contributor

@bgutsol bgutsol commented Dec 6, 2023

Purpose of PR

  • allow having icons with a small Badge component. We need this update to use in the Visual Modeler fields details. cc @handekocabey86

Copy link

changeset-bot bot commented Dec 6, 2023

🦋 Changeset detected

Latest commit: 91245d3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@contentful/f36-badge Minor
@contentful/f36-accordion Minor
@contentful/f36-asset Minor
@contentful/f36-autocomplete Minor
@contentful/f36-button Minor
@contentful/f36-card Minor
@contentful/f36-collapse Minor
@contentful/f36-copybutton Minor
@contentful/f36-core Minor
@contentful/f36-datetime Minor
@contentful/f36-datepicker Minor
@contentful/f36-drag-handle Minor
@contentful/f36-entity-list Minor
@contentful/f36-empty-state Minor
@contentful/f36-forms Minor
@contentful/f36-icon Minor
@contentful/f36-list Minor
@contentful/f36-menu Minor
@contentful/f36-modal Minor
@contentful/f36-note Minor
@contentful/f36-notification Minor
@contentful/f36-pagination Minor
@contentful/f36-pill Minor
@contentful/f36-popover Minor
@contentful/f36-skeleton Minor
@contentful/f36-spinner Minor
@contentful/f36-table Minor
@contentful/f36-tabs Minor
@contentful/f36-text-link Minor
@contentful/f36-tooltip Minor
@contentful/f36-typography Minor
@contentful/f36-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Dec 6, 2023 3:15pm

Copy link

github-actions bot commented Dec 6, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 129.74 KB (+0.03% 🔺) 2.6 s (+0.03% 🔺) 274 ms (-14% 🔽) 2.9 s
Module 126.23 KB (+0.03% 🔺) 2.6 s (+0.03% 🔺) 275 ms (-10.25% 🔽) 2.8 s

Copy link
Collaborator

@cf-remylenoir cf-remylenoir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I would appreciate getting a design approval too 👀

@handekocabey86 handekocabey86 merged commit bc1d1b0 into main Dec 6, 2023
12 checks passed
@handekocabey86 handekocabey86 deleted the badge-size branch December 6, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants