Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add onClick prop to breadcrumb [CFCX-1433] #2708

Merged
merged 8 commits into from
Apr 15, 2024
Merged

feat: add onClick prop to breadcrumb [CFCX-1433] #2708

merged 8 commits into from
Apr 15, 2024

Conversation

massao
Copy link
Contributor

@massao massao commented Apr 11, 2024

Purpose of PR

We want to be able to pass custom onClick to breadcrumb to be able to use tracking and similars.

@massao massao requested review from damann and a team as code owners April 11, 2024 08:13
Copy link

changeset-bot bot commented Apr 11, 2024

⚠️ No Changeset found

Latest commit: ecdf76a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Apr 12, 2024 0:58am

Copy link

github-actions bot commented Apr 11, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 130.55 KB (0%) 2.7 s (0%) 95 ms (+74.37% 🔺) 2.8 s
Module 127.48 KB (0%) 2.6 s (0%) 91 ms (+44.8% 🔺) 2.7 s

Copy link
Collaborator

@denkristoffer denkristoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget the changeset.

@massao
Copy link
Contributor Author

massao commented Apr 11, 2024

Don't forget the changeset.

This is still in alpha, adding changeset ignores alpha and beta currently, something that we need to take a look into as well.
To improve how the prereleases works

Copy link
Collaborator

@denkristoffer denkristoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well in that case!

Copy link
Contributor

@miguelcrespo miguelcrespo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be cool to update the documentation to show this new possibility:
https://f36.contentful.com/components/header
File:

Copy link
Collaborator

@Lelith Lelith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@massao massao merged commit 0d5e551 into main Apr 15, 2024
12 checks passed
@massao massao deleted the CFCX-1433 branch April 15, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants