Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove postinstall script #2824

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

cf-remylenoir
Copy link
Collaborator

@cf-remylenoir cf-remylenoir commented Jul 15, 2024

Purpose of PR

Removes the postinstall script, one can use the generic build command when needed.

This unblocks Netlify's dry-run build which tries to access turbo when it isn't installed yet.

Alternative: move Storybook's production build & deployment to Vercel.

@cf-remylenoir cf-remylenoir requested review from damann and a team as code owners July 15, 2024 13:42
Copy link

vercel bot commented Jul 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Jul 15, 2024 1:44pm

Copy link

changeset-bot bot commented Jul 15, 2024

⚠️ No Changeset found

Latest commit: 0c04fb2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 138.29 KB (0%) 2.8 s (0%) 143 ms (+69.9% 🔺) 3 s
Module 134.6 KB (0%) 2.7 s (0%) 143 ms (+56.95% 🔺) 2.9 s

@cf-remylenoir cf-remylenoir merged commit 8b4ea34 into main Jul 16, 2024
15 checks passed
@cf-remylenoir cf-remylenoir deleted the build-remove-postinstall branch July 16, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants