Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use imports for css, and svg instead of require #404

Merged
merged 4 commits into from
Jan 27, 2020
Merged

Use imports for css, and svg instead of require #404

merged 4 commits into from
Jan 27, 2020

Conversation

mshaaban0
Copy link
Collaborator

Purpose of PR

Change require() to import for both svg and css file imports for convention; this is also help in building esm bundle with rollup.

PR Checklist

  • I have read the relevant readme.md file(s)
  • All commits follow our Git commit message convention
  • Tests are added/updated/not required
  • Tests are passing
  • Storybook stories are added/updated/not required
  • Usage notes are added/updated/not required
  • Has been tested based on Contentful's browser support
  • Doesn't contain any sensitive information

@mshaaban0 mshaaban0 merged commit 34754ee into master Jan 27, 2020
@mshaaban0 mshaaban0 deleted the fix/esm-bundle branch January 27, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suevalov suevalov suevalov approved these changes

@wichniowski wichniowski Awaiting requested review from wichniowski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mshaaban0 @suevalov