Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Select,Input): Fixes a lack of background-color for Select #79

Merged
merged 3 commits into from
Feb 11, 2019
Merged

fix(Select,Input): Fixes a lack of background-color for Select #79

merged 3 commits into from
Feb 11, 2019

Conversation

suevalov
Copy link
Contributor

@suevalov suevalov commented Feb 11, 2019 •
edited
Loading

Purpose of PR

Fixes transparent background for Select component and adds explicit background for Input component.

screenshot 2019-02-11 at 14 13 00

PR Checklist

  • I have read the relevant readme.md file(s)
  • All commits follow our Git commit message convention
  • Tests are added/updated/not required
  • Tests are passing
  • Storybook stories are added/updated/not required
  • Usage notes are added/updated/not required
  • Has been tested based on Contentful's browser support
  • Doesn't contain any sensitive information

wichniowski
wichniowski approved these changes Feb 11, 2019
View reviewed changes
Copy link
Contributor

@wichniowski wichniowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@suevalov suevalov merged commit 6dc71e1 into master Feb 11, 2019
@suevalov suevalov deleted the fix-select-background branch February 11, 2019 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wichniowski wichniowski wichniowski approved these changes

@m10l m10l m10l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@suevalov @wichniowski @m10l