Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ToggleButton): Refactor ToggleButton to TS #84

Merged
merged 2 commits into from
Feb 13, 2019
Merged

refactor(ToggleButton): Refactor ToggleButton to TS #84

merged 2 commits into from
Feb 13, 2019

Conversation

suevalov
Copy link
Contributor

@suevalov suevalov commented Feb 12, 2019 •
edited
Loading

Purpose of PR

  • Refactor ToggleButton to Typescript
  • Link Checkbox and RadioButton typings to index.d.ts

PR Checklist

  • I have read the relevant readme.md file(s)
  • All commits follow our Git commit message convention
  • Tests are added/updated/not required
  • Tests are passing
  • Storybook stories are added/updated/not required
  • Usage notes are added/updated/not required
  • Has been tested based on Contentful's browser support
  • Doesn't contain any sensitive information

wichniowski
wichniowski approved these changes Feb 13, 2019
View reviewed changes
Copy link
Contributor

@wichniowski wichniowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@suevalov suevalov merged commit 51ae26a into master Feb 13, 2019
@suevalov suevalov deleted the toggle-button-typescript branch February 13, 2019 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wichniowski wichniowski wichniowski approved these changes

@m10l m10l Awaiting requested review from m10l

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@suevalov @wichniowski