Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: equal left & right paddings in a dropdown button #902

Merged
merged 3 commits into from
Apr 1, 2021
Merged

fix: equal left & right paddings in a dropdown button #902

merged 3 commits into from
Apr 1, 2021

Conversation

Chaoste
Copy link
Contributor

@Chaoste Chaoste commented Mar 30, 2021 •
edited
Loading

Purpose of PR

A medium or large button with indicateDropdown being true has a too small right-padding. The paddings should be the same on both sides. Right now this is only the case for a small button since its CSS styles have a higher specificity than ".is--dropdown".

PR Checklist

  • I have read the relevant readme.md file(s)
  • All commits follow our Git commit message convention
  • Tests are added/updated/not required
  • Tests are passing
  • Storybook stories are added/updated/not required
  • Usage notes are added/updated/not required
  • Has been tested based on Contentful's browser support
  • Doesn't contain any sensitive information

Before:
Screenshot 2021-03-30 at 13 47 10
Screenshot 2021-03-30 at 13 47 25
Screenshot 2021-03-30 at 13 47 40

After:
Screenshot 2021-03-30 at 13 48 03
Screenshot 2021-03-30 at 13 47 49

@Chaoste
fix(button): keep equal paddings for left and right side of a dropdow…
366d1d2 
…n button

Medium and large buttons have less right padding than left padding.
@Chaoste Chaoste changed the title fix: Equal left & right paddings in a dropdown button fix: equal left & right paddings in a dropdown button Mar 30, 2021
@netlify
Copy link

netlify bot commented Mar 30, 2021 •
edited
Loading

Deploy preview for forma-36 ready!

Built with commit 47f8c67

https://deploy-preview-902--forma-36.netlify.app

@denkristoffer
Copy link
Collaborator

@domarku @fabe Can you review here? 🙂

@domarku
Copy link
Contributor

domarku commented Apr 1, 2021

It was a conscious design decision (back in the day) to make the padding on the right smaller but I don't see why we should keep it.

@denkristoffer denkristoffer merged commit 334c598 into master Apr 1, 2021
@denkristoffer denkristoffer deleted the fix/dropdown-button-padding branch April 1, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabe fabe fabe approved these changes

@domarku domarku domarku approved these changes

@burakukula burakukula Awaiting requested review from burakukula

@denkristoffer denkristoffer Awaiting requested review from denkristoffer

@gui-santos gui-santos Awaiting requested review from gui-santos

@m10l m10l Awaiting requested review from m10l

@mshaaban0 mshaaban0 Awaiting requested review from mshaaban0

@nikazawila nikazawila Awaiting requested review from nikazawila

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Chaoste @denkristoffer @domarku @fabe