feat: Machine Readable Formats for DateTime with DATE_ONLY or TIME_ONLY #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chaoste
requested review from
burakukula,
denkristoffer,
gui-santos,
m10l,
mshaaban0 and
nikazawila
as code owners
Chaoste
force-pushed
the
fix/datetime-attribute
branch
from
e831621
to
1b15b3d
Compare
|
Deploy preview for forma-36 ready! Built with commit e831621 |
|
Deploy preview for forma-36 ready! Built with commit f761071 |
packages/forma-36-react-components/src/components/DateTime/DateTime.test.tsx
Outdated
Show resolved
Hide resolved
mshaaban0
approved these changes
Apr 19, 2021
packages/forma-36-react-components/src/components/DateTime/DateTime.test.tsx
Show resolved
Hide resolved
packages/forma-36-react-components/src/components/DateTime/DateTime.test.tsx
Outdated
Show resolved
Hide resolved
|
@all-contributors please add @Chaoste for bug, code |
|
I've put up a pull request to add @Chaoste! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR
When one uses DateTime only showing the date or time, the
datetimeattribute should represent that, too.I followed the respective MDN docs regarding which formats are allowed.
PR Checklist
readme.mdfile(s)