feat(Tabs): Created Tabs component #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wichniowski
approved these changes
Feb 18, 2019
| } | ||
| return <a {...elementProps}>{children}</a>; | ||
| } else { | ||
| elementProps['aria-selected'] = selected; |
packages/forma-36-react-components/src/components/Tabs/Tabs.css
Outdated
Show resolved
Hide resolved
| extends React.DetailedHTMLProps< | ||
| React.HTMLAttributes<HTMLDivElement>, | ||
| HTMLDivElement | ||
| > { |
There was a problem hiding this comment.
Why do you need this? Just curious.
There was a problem hiding this comment.
Because API allows using (with ...rest) all HTML properties that you would normally use with <div />
suevalov
force-pushed
the
create-tab-component
branch
from
5607e96
to
e936a81
Compare
suevalov
force-pushed
the
create-tab-component
branch
from
e936a81
to
53789e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR
This PR introduces new set of components:
Tabs,TabandTabPanel.TabsandTabPanelhave no styles and used only for logical composition and hiding all required ARIA-attributes.PR Checklist
readme.mdfile(s)