Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(forma-36-fcss): Moved postcss from deps to devDeps #98

Merged
merged 1 commit into from
Feb 20, 2019
Merged

build(forma-36-fcss): Moved postcss from deps to devDeps #98

merged 1 commit into from
Feb 20, 2019

Conversation

suevalov
Copy link
Contributor

@suevalov suevalov commented Feb 20, 2019 •
edited
Loading

Purpose of PR

postcss is a developer dependency for forma-36-fcss package and it shouldn't be installed when forma-36-fcss is used in the app

PR Checklist

  • I have read the relevant readme.md file(s)
  • All commits follow our Git commit message convention
  • Tests are added/updated/not required
  • Tests are passing
  • Storybook stories are added/updated/not required
  • Usage notes are added/updated/not required
  • Has been tested based on Contentful's browser support
  • Doesn't contain any sensitive information

@suevalov suevalov merged commit b4f5cab into master Feb 20, 2019
@suevalov suevalov deleted the fix-deps-in-fss branch February 20, 2019 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wichniowski wichniowski wichniowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@suevalov @wichniowski