Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set repository url #354

Merged
merged 1 commit into from
Sep 26, 2023
Merged

fix: set repository url #354

merged 1 commit into from
Sep 26, 2023

Conversation

jjolton-contentful
Copy link
Contributor

documentation for this package.json field

tl;dr:

Specify the place where your code lives. This is helpful for people who want to contribute. If the git repo is on GitHub, then the npm docs command will be able to find you.

Without this, the CONTRIBUTING.md link fails when clicked via the npm homepage.

@jjolton-contentful jjolton-contentful force-pushed the fix/contributing-link-on-npm branch 2 times, most recently from 757f1e1 to 57c3ba3 Compare September 22, 2023 20:00
@jjolton-contentful jjolton-contentful marked this pull request as draft September 22, 2023 20:00
@jjolton-contentful
Copy link
Contributor Author

figuring out why my commits aren't being verified, will reopen after that is sorted

@jjolton-contentful jjolton-contentful force-pushed the fix/contributing-link-on-npm branch 3 times, most recently from 50e4e93 to a516409 Compare September 22, 2023 20:12
@jjolton-contentful jjolton-contentful marked this pull request as ready for review September 22, 2023 20:13
@jjolton-contentful jjolton-contentful requested a review from a team as a code owner September 25, 2023 19:31
ghepting
ghepting reviewed Sep 26, 2023
View reviewed changes
package.json
@@ -60,5 +60,9 @@
"*.ts": [
"npm run lint:fix"
]
},
"repository": {
"url": "github:contentful/node-apps-toolkit",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL you can put not-URLs in the url config values: https://docs.npmjs.com/cli/v10/configuring-npm/package-json#repository

@jjolton-contentful jjolton-contentful merged commit a0b7dcc into master Sep 26, 2023
7 checks passed
@jjolton-contentful jjolton-contentful deleted the fix/contributing-link-on-npm branch September 26, 2023 14:59
contentful-automation bot added a commit that referenced this pull request Sep 26, 2023
@contentful-automation
chore(release): 2.7.1 [skip ci]
4ca5de9 
## [2.7.1](v2.7.0...v2.7.1) (2023-09-26)

### Bug Fixes

* npm update after node upgrade ([#366](#366)) ([9269a3e](9269a3e))
* set repository url to allow CONTRIBUTING.md link to work from npm page ([#354](#354)) ([a0b7dcc](a0b7dcc))
@contentful-automation
Copy link
Contributor

🎉 This PR is included in version 2.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghepting ghepting ghepting approved these changes

@t-col t-col t-col approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jjolton-contentful @ghepting @t-col