Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove deprecated props & methods [EXT-4467] #1597

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

andipaetzold
Copy link
Contributor

@andipaetzold andipaetzold commented Jul 21, 2023

BREAKING CHANGE: removed deprecated props & methods

BREAKING CHANGE: removed deprecated props & methods
@andipaetzold andipaetzold changed the base branch from master to v5.0.0-wip July 21, 2023 11:33
@andipaetzold andipaetzold self-assigned this Jul 21, 2023
@andipaetzold andipaetzold requested a review from a team July 21, 2023 11:33
@andipaetzold andipaetzold marked this pull request as ready for review July 21, 2023 11:35
@andipaetzold andipaetzold requested a review from a team as a code owner July 21, 2023 11:35
@andipaetzold andipaetzold changed the title feat: remove deprecated props & methods feat: remove deprecated props & methods [EXT-4467] Jul 21, 2023
/**
* @deprecated use `editors` instead
*/
editor?: boolean
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did we deprecate this? isn't this a slight regression in DX?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally, EditorInterface only had one editor. At some point, we allowed having multiple editors for one content type (the tabs [editor, reference, tags]). At that point editor was deprecated with editors.

The original editor boolean doesn't allow you to specify instance parameters or the position of the app. editors allows that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, that makes more sense now! ty 😄

@@ -19,8 +19,6 @@ export const actionSelectors = {

export const widgetLocation = {
entryField: 'entry-field',
/** @deprecated */
entryFieldSidebar: 'entry-field-sidebar',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is deprecated simply because this concept was specific to legacy UI extensions, right? (field editor as a sidebar extension?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. entry field sidebar is extensions only

@andipaetzold andipaetzold merged commit 7f7240b into v5.0.0-wip Jul 21, 2023
4 checks passed
@andipaetzold andipaetzold deleted the remove-deprecated branch July 21, 2023 13:17
contentful-automation bot added a commit that referenced this pull request Jul 21, 2023
# [5.0.0-alpha.2](v5.0.0-alpha.1...v5.0.0-alpha.2) (2023-07-21)

### Features

* add options for openEntriesList and openAssetsList [EXT-4514 EXT-4618] ([#1596](#1596)) ([22d08a6](22d08a6))
* do not bundle package [EXT-3598] ([#1590](#1590)) ([e95c81a](e95c81a)), closes [#1577](#1577) [#1579](#1579) [#1580](#1580) [#1581](#1581) [#1574](#1574) [#1576](#1576)
* remove deprecated props & methods [EXT-4467] ([#1597](#1597)) ([7f7240b](7f7240b))

### BREAKING CHANGES

* removed deprecated props & methods
@contentful-automation
Copy link
Contributor

🎉 This PR is included in version 5.0.0-alpha.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

ghepting pushed a commit that referenced this pull request Aug 14, 2023
feat: remove deprecated props & methods

BREAKING CHANGE: removed deprecated props & methods
ghepting pushed a commit that referenced this pull request Aug 14, 2023
# [5.0.0-alpha.2](v5.0.0-alpha.1...v5.0.0-alpha.2) (2023-07-21)

### Features

* add options for openEntriesList and openAssetsList [EXT-4514 EXT-4618] ([#1596](#1596)) ([22d08a6](22d08a6))
* do not bundle package [EXT-3598] ([#1590](#1590)) ([e95c81a](e95c81a)), closes [#1577](#1577) [#1579](#1579) [#1580](#1580) [#1581](#1581) [#1574](#1574) [#1576](#1576)
* remove deprecated props & methods [EXT-4467] ([#1597](#1597)) ([7f7240b](7f7240b))

### BREAKING CHANGES

* removed deprecated props & methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants