-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove deprecated props & methods [EXT-4467] #1597
Conversation
BREAKING CHANGE: removed deprecated props & methods
/** | ||
* @deprecated use `editors` instead | ||
*/ | ||
editor?: boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did we deprecate this? isn't this a slight regression in DX?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Originally, EditorInterface only had one editor. At some point, we allowed having multiple editors for one content type (the tabs [editor, reference, tags]). At that point editor
was deprecated with editors
.
The original editor
boolean doesn't allow you to specify instance parameters or the position of the app. editors
allows that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, that makes more sense now! ty 😄
@@ -19,8 +19,6 @@ export const actionSelectors = { | |||
|
|||
export const widgetLocation = { | |||
entryField: 'entry-field', | |||
/** @deprecated */ | |||
entryFieldSidebar: 'entry-field-sidebar', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is deprecated simply because this concept was specific to legacy UI extensions, right? (field editor as a sidebar extension?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. entry field sidebar is extensions only
# [5.0.0-alpha.2](v5.0.0-alpha.1...v5.0.0-alpha.2) (2023-07-21) ### Features * add options for openEntriesList and openAssetsList [EXT-4514 EXT-4618] ([#1596](#1596)) ([22d08a6](22d08a6)) * do not bundle package [EXT-3598] ([#1590](#1590)) ([e95c81a](e95c81a)), closes [#1577](#1577) [#1579](#1579) [#1580](#1580) [#1581](#1581) [#1574](#1574) [#1576](#1576) * remove deprecated props & methods [EXT-4467] ([#1597](#1597)) ([7f7240b](7f7240b)) ### BREAKING CHANGES * removed deprecated props & methods
🎉 This PR is included in version 5.0.0-alpha.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
feat: remove deprecated props & methods BREAKING CHANGE: removed deprecated props & methods
# [5.0.0-alpha.2](v5.0.0-alpha.1...v5.0.0-alpha.2) (2023-07-21) ### Features * add options for openEntriesList and openAssetsList [EXT-4514 EXT-4618] ([#1596](#1596)) ([22d08a6](22d08a6)) * do not bundle package [EXT-3598] ([#1590](#1590)) ([e95c81a](e95c81a)), closes [#1577](#1577) [#1579](#1579) [#1580](#1580) [#1581](#1581) [#1574](#1574) [#1576](#1576) * remove deprecated props & methods [EXT-4467] ([#1597](#1597)) ([7f7240b](7f7240b)) ### BREAKING CHANGES * removed deprecated props & methods
BREAKING CHANGE: removed deprecated props & methods