Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(specs): Introduce 'improvement' type #32

Closed
wants to merge 1 commit into from
Closed

feat(specs): Introduce 'improvement' type #32

wants to merge 1 commit into from

Conversation

damianopetrungaro
Copy link
Member

@stevemao let me know what do you think.
I saw in another PR that we'll use noun instead of verb, so improvement is used instead of improve

@damianopetrungaro
Copy link
Member Author

@stevemao @bcoe take a look here

@ungoldman
Copy link

I think this concept is already covered by refactor (see https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#type), which should not trigger a version bump.

@damianopetrungaro
Copy link
Member Author

Refactor means no breaking changes are made.
Improvement may break APIs but it's not a feature neither a fix.

@bcoe
Copy link
Contributor

bcoe commented Mar 16, 2018

@damianopetrungaro sorry for the slow turnaround, don't have a ton of time for open-source these days unfortunately.

There's nothing in the spec that stops you from using the improvement verb; but functionality it's fairly similar to feat and I think at this time I'd like to avoid adding it to the spec itself.

If you'd like to add it as a recommended verb to the Others:, perhaps we can make the recommendation here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants