Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: link to Angular Commit Guidelines #59

Merged
merged 1 commit into from
May 31, 2018
Merged

fix: link to Angular Commit Guidelines #59

merged 1 commit into from
May 31, 2018

Conversation

JaKXz
Copy link
Contributor

@JaKXz JaKXz commented May 31, 2018 •
edited
Loading

Using a commit hash so the link isn't incorrect as [long as] the repo lives :)

@damianopetrungaro
Copy link
Member

damianopetrungaro commented May 31, 2018 •
edited
Loading

Welcome @JaKXz !
Thank you for your first contribution 😄
Let me review it 😄

damianopetrungaro
damianopetrungaro requested changes May 31, 2018
View reviewed changes
Copy link
Member

@damianopetrungaro damianopetrungaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update all the links pointing to the wrong Angular URL in the project and update it?

If should be pretty easy, let me know if you haven't time to do it 😄

@JaKXz
Copy link
Contributor Author

JaKXz commented May 31, 2018

Fixed :)

@damianopetrungaro
Copy link
Member

@bcoe I just noticed that @JaKXz is pointing to angular/angular.js repo.
angular/angular repo have the same content too. (link here)
Which one would you suggest to use?
I'd prefer angular/angular

@bcoe
Copy link
Contributor

bcoe commented May 31, 2018

I agree let's use the angular repo, I think that's more correct. work for you @JaKXz?

@JaKXz
Copy link
Contributor Author

JaKXz commented May 31, 2018

on it!

@JaKXz
Copy link
Contributor Author

JaKXz commented May 31, 2018

@bcoe @damianopetrungaro done!

@damianopetrungaro
Copy link
Member

Cool, look good to me!
Thank you @JaKXz for your first contribution!

@damianopetrungaro damianopetrungaro merged commit 921a29d into conventional-commits:master May 31, 2018
@JaKXz JaKXz deleted the patch-1 branch May 31, 2018 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damianopetrungaro damianopetrungaro damianopetrungaro requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JaKXz @damianopetrungaro @bcoe