-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove docker binding to port 80 #72
Conversation
@zeke what error message did you have? The docker-compose file you see is only used for development purposes, so we can change it without BC in our production environment. The line you deleted is used to bind the internal port 4000 to the 80 on your machine. Let me know 😄 |
See #71
I don't recall having done any custom port configuration on my machine before. |
@zeke Run
|
|
The process with ID It's a docker process, try restarting docker so you'll kill all the processes and no one will be listening to that door and you'll be sure you will be able to use it. btw changing the port you are binding from the container to your machine, you should be able to see the website up and running 😄 Using this:
then Let me know if you have any other doubt 😄 |
I was able to get
docker-compose up
to work by removing this line.@damianopetrungaro is this line needed? I don't know how the site is currently deployed.
Resolves #71