Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #154

Closed
pykong opened this issue Feb 28, 2020 · 2 comments · Fixed by #437
Closed

Update CONTRIBUTING.md #154

pykong opened this issue Feb 28, 2020 · 2 comments · Fixed by #437
Labels
good first issue Easy things for newbies

Comments

@pykong
Copy link
Collaborator

pykong commented Feb 28, 2020

Once the dev setup has stabilized it will be time to reflect the changes back into the dev docs:
CONTRIBUTING.md.

See also: #129 #132

@yajo yajo added the good first issue Easy things for newbies label May 10, 2020
nat-n added a commit to nat-n/copier that referenced this issue Aug 16, 2020
The new `[tool.poe.tasks]` section and new poetry based workflow are a complete
replacement for the makefile which has also been removed.
nat-n added a commit to nat-n/copier that referenced this issue Aug 17, 2020
…a complete

replacement for the makefile which has also been removed.

Also
- update CONTRIBUTING.MD copier-org#154 to keep things coherent
- add tox dev dep and config to pyproject.toml
nat-n added a commit to nat-n/copier that referenced this issue Aug 17, 2020
…a complete

replacement for the makefile which has also been removed.

Also
- update CONTRIBUTING.MD copier-org#154 to keep things coherent
- add tox dev dep and config to pyproject.toml
nat-n added a commit to nat-n/copier that referenced this issue Aug 21, 2020
The new `[tool.poe.tasks]` section and new poetry based workflow are a complete
replacement for the makefile which has also been removed. copier-org#129

Also:
- add devtasks for python functions to be referenced as poe tasks
- update CONTRIBUTING.MD copier-org#154 to keep things coherent
  - remove reference to tox
- update ci to work with more expressive toml syntax (upgrade pip)
  - and use poe tasks in ci
yajo pushed a commit that referenced this issue Aug 21, 2020
The new `[tool.poe.tasks]` section and new poetry based workflow are a complete
replacement for the makefile which has also been removed. #129

Also:
- add devtasks for python functions to be referenced as poe tasks
- update CONTRIBUTING.MD #154 to keep things coherent
  - remove reference to tox
- update ci to work with more expressive toml syntax (upgrade pip)
  - and use poe tasks in ci
@pawamoy
Copy link
Contributor

pawamoy commented May 4, 2021

Seeing how you improved CONTRIBUTING.md in this commit, maybe this issue could be closed?

Maybe just one thing I noticed: you track VSCode settings and set the path to the interpreter to .venv/bin/python, but if contributors do not tell Poetry to install the venv in the project, they will have to change that setting:

-  "python.pythonPath": ".venv/bin/python"
+  "python.pythonPath": "/home/pawamoy/.cache/pypoetry/virtualenvs/copier-AExR1Oeb-py3.9/bin/python"

Not sure how to circumvent that though.

@yajo
Copy link
Member

yajo commented May 6, 2021

Yes, that's because of microsoft/vscode-python#8372. For now, the only way to use both tools sanely and share out-of-the-box settings is to tell poetry to save the venv local to the project.

I should document that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Easy things for newbies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants