Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use dataclass field instead of Pydantic field #1249

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

sisp
Copy link
Member

@sisp sisp commented Jul 14, 2023

Pydantic v2 prior to v2.0.3 had a bug related to using a Pydantic dataclass with a vanilla dataclass field with a default factory and init=False which required a workaround on our side to use Pydantic's Field() instead of vanilla field(). Since this bug has been fixed in v2.0.3, I've removed the workaround and bumped our minimum required Pydantic version to v2.0.3.

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #1249 (8c33d29) into master (9888571) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1249      +/-   ##
==========================================
+ Coverage   96.72%   96.77%   +0.05%     
==========================================
  Files          47       47              
  Lines        3935     3935              
==========================================
+ Hits         3806     3808       +2     
+ Misses        129      127       -2     
Flag Coverage Δ
unittests 96.77% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
copier/main.py 95.66% <100.00%> (ø)
copier/user_data.py 94.65% <100.00%> (ø)

... and 1 file with indirect coverage changes

@yajo yajo merged commit 568de4e into copier-org:master Jul 17, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants