-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: drop support for Python 3.7 #1252
Conversation
e2ab8f9
to
6623209
Compare
Codecov Report
@@ Coverage Diff @@
## master #1252 +/- ##
==========================================
+ Coverage 96.79% 96.85% +0.06%
==========================================
Files 47 47
Lines 3930 3881 -49
==========================================
- Hits 3804 3759 -45
+ Misses 126 122 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
c4ea6fb
to
c019c3d
Compare
On Windows, `shutil.rmtree` does not handle read-only files very well. This handler | ||
makes sure the given file is writable, then re-execute the given removal function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems thatshutil.rmtree
doesn't only have this issue under Python <3.8 on Windows. See the Windows CI checks when I had this handler removed: https://github.com/copier-org/copier/actions/runs/5573531416
It seems okay to remove the custom TemporaryDirectory
class though. I hope that's actually correct and not just uncovered by tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the handle_remove_readonly
utility still used somewhere else in the code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, only in template.Template._cleanup
.
I think this PR is ready for a review now. I'm not sure why there are 3 |
c019c3d
to
34c82c1
Compare
That was due to repo settings. Fixed now. |
34c82c1
to
fe6887c
Compare
Checks are passing now. 🎉 |
@yajo Haha, looks like I'm still struggling with the commit change types. 😆 I was actually wondering whether |
I've dropped support for Python 3.7. Resolves #1251.