Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: drop support for Python 3.7 #1252

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Conversation

sisp
Copy link
Member

@sisp sisp commented Jul 17, 2023

I've dropped support for Python 3.7. Resolves #1251.

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #1252 (fe6887c) into master (295d35a) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1252      +/-   ##
==========================================
+ Coverage   96.79%   96.85%   +0.06%     
==========================================
  Files          47       47              
  Lines        3930     3881      -49     
==========================================
- Hits         3804     3759      -45     
+ Misses        126      122       -4     
Flag Coverage Δ
unittests 96.85% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_dirty_local.py 100.00% <ø> (ø)
copier/main.py 95.79% <100.00%> (+0.13%) ⬆️
copier/subproject.py 97.36% <100.00%> (-0.20%) ⬇️
copier/template.py 96.24% <100.00%> (-0.07%) ⬇️
copier/tools.py 95.71% <100.00%> (+1.39%) ⬆️
copier/types.py 87.87% <100.00%> (-1.02%) ⬇️
copier/user_data.py 94.95% <100.00%> (+0.30%) ⬆️
copier/vcs.py 97.05% <100.00%> (-0.03%) ⬇️
tests/helpers.py 97.22% <100.00%> (-0.12%) ⬇️
tests/test_subdirectory.py 100.00% <100.00%> (ø)
... and 3 more

... and 2 files with indirect coverage changes

@sisp sisp force-pushed the build/drop-python-37 branch 2 times, most recently from c4ea6fb to c019c3d Compare July 17, 2023 09:00
Comment on lines +143 to +138
On Windows, `shutil.rmtree` does not handle read-only files very well. This handler
makes sure the given file is writable, then re-execute the given removal function.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems thatshutil.rmtree doesn't only have this issue under Python <3.8 on Windows. See the Windows CI checks when I had this handler removed: https://github.com/copier-org/copier/actions/runs/5573531416

It seems okay to remove the custom TemporaryDirectory class though. I hope that's actually correct and not just uncovered by tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the handle_remove_readonly utility still used somewhere else in the code?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sisp
Copy link
Member Author

sisp commented Jul 17, 2023

I think this PR is ready for a review now.

I'm not sure why there are 3 build (<OS>-latest, 3.7) jobs, they shouldn't exist because I removed "3.7" from the CI matrix. 🤔

@yajo
Copy link
Member

yajo commented Jul 18, 2023

That was due to repo settings. Fixed now.

@sisp
Copy link
Member Author

sisp commented Jul 18, 2023

Checks are passing now. 🎉

@yajo yajo merged commit a82c0ad into copier-org:master Jul 18, 2023
17 checks passed
@sisp sisp deleted the build/drop-python-37 branch July 18, 2023 19:04
@sisp
Copy link
Member Author

sisp commented Jul 18, 2023

@yajo Haha, looks like I'm still struggling with the commit change types. 😆 I was actually wondering whether build: was a bad choice because it wouldn't appear in the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants