Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: enable more ruff lints #1558

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

danieleades
Copy link
Contributor

enables additional ruff lints

this should not be merged yet- the FURB lint group is preview only, so pre-commit will need to be updated to use the --preview flag in order to use these lints. I've got no idea how to configure this using flake/nix

I've run ruff over this locally with that flag, so the changes have been applied, but we'll want to make sure they continue to be checked in CI

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 93.61702% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 97.30%. Comparing base (0fb2d06) to head (448c53e).

Files Patch % Lines
devtasks.py 0.00% 1 Missing ⚠️
tests/test_config.py 0.00% 1 Missing ⚠️
tests/test_prompt.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1558      +/-   ##
==========================================
+ Coverage   97.28%   97.30%   +0.01%     
==========================================
  Files          48       48              
  Lines        4603     4599       -4     
==========================================
- Hits         4478     4475       -3     
+ Misses        125      124       -1     
Flag Coverage Δ
unittests 97.30% <93.61%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you solve the conflicts please? Anything left before getting out of draft?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants