modules/ignition,platforms/*: Add option to start iscsid service => master #2713
Conversation
Allows iscsid service to be started for environments that need to attach iscsi volumes to nodes.
|
Can one of the admins verify this patch? |
trawler
force-pushed
the
kalmog_iscsi_master
branch
from
b2ef773
to
a7d3934
Compare
trawler
changed the title
|
test this please |
|
test this please |
trawler
force-pushed
the
kalmog_iscsi_master
branch
from
a7d3934
to
706874e
Compare
trawler
force-pushed
the
kalmog_iscsi_master
branch
from
706874e
to
3c17ba9
Compare
| @@ -49,6 +49,8 @@ systemd: | |||
| - name: tectonic.service | |||
| enable: false | |||
| contents: {{.ign_tectonic_service_json}} | |||
| - name: iscsid.service | |||
| enable: {{.iscsi.enabled}} | |||
There was a problem hiding this comment.
There was an unfortunate typo here (#2748). However I'm concerned that neither reviews nor tests blocked this.
There was a problem hiding this comment.
it blocked, but unfortunately for this PR it was not set to run on bare metal. we saw the issue when we run the nightly in master 😢
There was a problem hiding this comment.
This is a side effect of relying on human intervention for setting the labels for running the tests. This needs to be automated so we ensure by code that relevant tests are run when needed
There was a problem hiding this comment.
agree, let's discuss to check what we can do.
but the code review that we do should check this as well if all relevant platform was covered
rebase of #2664