Update Electron to 28

Need to add node-gyp as devDep due to weird node 18.18 bug, see e.g. pulsar-edit/ppm#101
corneliusroemer · Aug 25, 2024 · db0fee5 · db0fee5
1 parent cf9a466
commit db0fee5
Show file tree

Hide file tree

Showing 7 changed files with 622 additions and 57 deletions.
diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-18.17
+18.18
diff --git a/app/package.json b/app/package.json
@@ -29,7 +29,7 @@
     "lodash": "4.17.21",
     "ms": "2.1.3",
     "native-process-working-directory": "^1.0.2",
-    "node-pty": "1.0.0",
+    "node-pty": "1.1.0-beta21",
     "os-locale": "5.0.0",
     "parse-url": "9.2.0",
     "queue": "6.0.2",
@@ -43,5 +43,8 @@
   },
   "optionalDependencies": {
     "native-reg": "1.1.1"
+  },
+  "devDependencies": {
+    "node-gyp": "^10.2.0"
   }
 }
diff --git a/app/patches/node-pty+1.0.0.patch b/app/patches/node-pty+1.0.0.patch