move testdata out of internal for re-use in integration tests

tests/integration/aminojson/aminojson_test.go

@@ -43,8 +43,8 @@ import (
 	ed25519types "github.com/cosmos/cosmos-sdk/crypto/keys/ed25519"
 	"github.com/cosmos/cosmos-sdk/crypto/keys/multisig"
 	secp256k1types "github.com/cosmos/cosmos-sdk/crypto/keys/secp256k1"
-	gogo_testpb "github.com/cosmos/cosmos-sdk/tests/integration/aminojson/internal/gogo/testpb"
-	pulsar_testpb "github.com/cosmos/cosmos-sdk/tests/integration/aminojson/internal/pulsar/testpb"
+	gogo_testpb "github.com/cosmos/cosmos-sdk/tests/integration/aminojson/testdata/gogo/testpb"
+	pulsar_testpb "github.com/cosmos/cosmos-sdk/tests/integration/aminojson/testdata/pulsar/testpb"
 	"github.com/cosmos/cosmos-sdk/tests/integration/rapidgen"
 	"github.com/cosmos/cosmos-sdk/testutil/testdata"
 	"github.com/cosmos/cosmos-sdk/types"

tests/integration/aminojson/repeated_test.go

@@ -10,9 +10,10 @@ import (
 	"github.com/stretchr/testify/require"
 
 	"cosmossdk.io/x/tx/signing/aminojson"
+
 	"github.com/cosmos/cosmos-sdk/codec"
-	gogopb "github.com/cosmos/cosmos-sdk/tests/integration/aminojson/internal/gogo/testpb"
-	pulsarpb "github.com/cosmos/cosmos-sdk/tests/integration/aminojson/internal/pulsar/testpb"
+	gogopb "github.com/cosmos/cosmos-sdk/tests/integration/aminojson/testdata/gogo/testpb"
+	pulsarpb "github.com/cosmos/cosmos-sdk/tests/integration/aminojson/testdata/pulsar/testpb"
 )
 
 func TestRepeatedFields(t *testing.T) {

tests/integration/tx/context_test.go

@@ -0,0 +1,30 @@
+package tx
+
+import (
+	"testing"
+
+	"cosmossdk.io/x/tx/signing"
+	"github.com/stretchr/testify/require"
+)
+
+func TestDefineCustomGetSigners(t *testing.T) {
+	customMsg := &testpb.CustomSignedMessage{}
+	signers := [][]byte{[]byte("foo")}
+
+	context, err := signing.NewContext(signing.Options{
+		AddressCodec:          dummyAddressCodec{},
+		ValidatorAddressCodec: dummyValidatorAddressCodec{},
+	})
+	require.NoError(t, err)
+
+	_, err = context.GetSigners(customMsg)
+	// before calling DefineCustomGetSigners, we should get an error
+	require.ErrorContains(t, err, "need custom signers function")
+	signing.DefineCustomGetSigners(context, func(msg *testpb.CustomSignedMessage) ([][]byte, error) {
+		return signers, nil
+	})
+	// after calling DefineCustomGetSigners, we should get the signers
+	gotSigners, err := context.GetSigners(customMsg)
+	require.NoError(t, err)
+	require.Equal(t, signers, gotSigners)
+}

x/tx/internal/testpb/1.proto

@@ -107,6 +107,7 @@ message Ballot {
   repeated WeightedBallotOption options = 4;
 }
 
+// TODO remove
 message CustomSignedMessage {
   option (cosmos.msg.v1.custom_signer) = true;
   string thing1 = 1;