Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify sender tags for ease of querying #3775

Closed
4 tasks
fedekunze opened this issue Mar 1, 2019 · 10 comments
Closed
4 tasks

unify sender tags for ease of querying #3775

fedekunze opened this issue Mar 1, 2019 · 10 comments
Assignees
Labels
T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine).
Milestone

Comments

@fedekunze
Copy link
Collaborator

fedekunze commented Mar 1, 2019

Summary of Bug

Governance txs don't follow tags standard

Steps to Reproduce

While most of the transactions from a delegator can be queried using the delegator=<address> tag. Governance txs don't follow this standard and thus clients have to additionally query each single tx independently. For eg:

For all txs from a delegator but governance:

GET /txs?delegator=<address>

For gov txs:

GET /txs?action=submit_proposal&proposer=<address>
GET /txs?action=deposit&depositor=<address>
GET /txs?action=vote&voter=<address>

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@fedekunze fedekunze added T:Bug API T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). labels Mar 1, 2019
@alexanderbez
Copy link
Contributor

I don't quite follow the proposal @fedekunze. Where is the bug here?

@fedekunze fedekunze removed the T:Bug label Mar 1, 2019
@fedekunze
Copy link
Collaborator Author

removed label as it's technically not a bug per se

@jackzampolin jackzampolin added this to the v0.35.0 milestone Mar 26, 2019
@jackzampolin
Copy link
Member

We should one tag that can be queried to return the list of transactions involving an address. Maybe this is something we could add as a flag to gaiacli q account

@fedekunze
Copy link
Collaborator Author

Or have a --from flag on gaiacli q txs

@jackzampolin
Copy link
Member

Like this call

@alexanderbez
Copy link
Contributor

I'm not sure if we should have --from as that may be confusing. Why not just query txs with sender=foo?

@fedekunze
Copy link
Collaborator Author

We already have that tag, but it’s not standard across all the modules

@fedekunze
Copy link
Collaborator Author

Also I’d like to get not only the ones I send but also the ones I receive, so maybe address=foo could be a better approach

@fedekunze fedekunze self-assigned this Apr 1, 2019
@fedekunze
Copy link
Collaborator Author

@faboweb said we should use sender on all transactions, it can be either a validator or delegator address. I like that idea

@jackzampolin
Copy link
Member

There should be an easy way to query all txns involving one address.

@fedekunze fedekunze changed the title governance transactions should use delegator tag unify sender tags for ease of querying Apr 5, 2019
@fedekunze fedekunze mentioned this issue Apr 5, 2019
5 tasks
alessio pushed a commit that referenced this issue Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine).
Projects
None yet
Development

No branches or pull requests

3 participants