feat: adding zerolog logging to cosmovisor

[spoo-bar]

Description

Closes: #10058

• Adding zerolog to cosmovisor
• Replacing zerolog logger instead of println

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[tac0turtle]

should we use the tendermint logger interface to be consistent with app.go?

[alexanderbez]

Not meaning to block here, but is there a reason to use a global here instead of just returning a logger instance?

[robert-zaremba]

You mean to have a function which returns a private instance? Or putting it in a context?

I think this is fine for the moment - it's still better than using fmt.Print*. Logger is not something that it's going to change during the runtime.

[robert-zaremba]

@spoo-bar - since nobody is blocking, feel free to add automerge unless you want to expand in this thread.

[alexanderbez]

Im not sure what you mean by private, but I mean just an instance, instead of relying on a global. So instead of requiring a SetupLogger call, you just call logger := CreateLogger().

[spoo-bar]

@alexanderbez creating an instance would require logger to be passed around to each function.
having a global makes it easy to call it from anywhere.

[alexanderbez]

creating an instance would require logger to be passed around to each function.

Not really, as the caller would would just call the function when it needs a logger (this is what SDK modules do BTW).

Also, globals are generally the root of all evil. Avoid them if possible (in most contexts).

[spoo-bar]

Ah okay.
But it would still require frequent reinitialization all over. Idk if having it has a global for a small component like cosmovisor is all that bad, is it?

[robert-zaremba]

You mean to have a function which returns a private instance? Or putting it in a context?

I think this is fine for the moment - it's still better than using fmt.Print*. Logger is not something that it's going to change during the runtime.

[spoo-bar]

@marbar3778 Using Zerolog directly, there are some really nice APIs we can use directly. Using the tendermint logger doesn't bring anything extra except consistency.
Additionally, cosmovisor currently isn't dependent on any cosmos or tendermint libraries. And adding a dependency just for logging might not be necessary in my opinion.

[codecov]

Codecov Report

Merging #10217 (d53deb2) into master (3138527) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10217      +/-   ##
==========================================
- Coverage   63.65%   63.65%   -0.01%     
==========================================
  Files         573      573              
  Lines       53761    53761              
==========================================
- Hits        34222    34221       -1     
- Misses      17590    17591       +1     
  Partials     1949     1949              

Impacted Files	Coverage Δ
crypto/keys/internal/ecdsa/privkey.go	82.45% <0.00%> (-1.76%)	⬇️