fix: x/bank/044 migrateDenomMetadata

x/bank/migrations/v044/keys.go

@@ -5,6 +5,9 @@ var (
 )
 
 func CreateAddressDenomPrefix(denom string) []byte {
-	key := append(DenomAddressPrefix, []byte(denom)...)
-	return append(key, 0)
+	key := make([]byte, len(DenomAddressPrefix)+len(denom)+1)
+	copy(key, DenomAddressPrefix)
+	copy(key[len(DenomAddressPrefix):], denom)
+	// key[last] = 0 - not needed, because this is the default
+	return key
 }

x/bank/migrations/v044/store.go

@@ -79,11 +79,14 @@ func migrateDenomMetadata(store sdk.KVStore) error {
 
 	for ; oldDenomMetaDataIter.Valid(); oldDenomMetaDataIter.Next() {
 		oldKey := oldDenomMetaDataIter.Key()
-		// old key: prefix_bytes | denom_bytes | denom_bytes
-		newKey := append(types.DenomMetadataPrefix, oldKey[:len(oldKey)/2+1]...)
+		l := len(oldKey)/2 + 1
 
+		var newKey = make([]byte, len(types.DenomMetadataPrefix)+l)
+		copy(newKey, types.DenomMetadataPrefix)
+		// old key: prefix_bytes | denom_bytes | denom_bytes
+		newKey = append(newKey, oldKey[:l]...)
 		store.Set(newKey, oldDenomMetaDataIter.Value())
-		oldDenomMetaDataStore.Delete(oldDenomMetaDataIter.Key())
+		oldDenomMetaDataStore.Delete(oldKey)
 	}
 
 	return nil

x/bank/types/key.go

@@ -60,6 +60,9 @@ func CreateAccountBalancesPrefix(addr []byte) []byte {
 // CreateDenomAddressPrefix creates a prefix for a reverse index of denomination
 // to account balance for that denomination.
 func CreateDenomAddressPrefix(denom string) []byte {
-	key := append(DenomAddressPrefix, []byte(denom)...)
-	return append(key, 0)
+	key := make([]byte, len(DenomAddressPrefix)+len(denom)+1)
+	copy(key, DenomAddressPrefix)
+	copy(key[len(DenomAddressPrefix):], denom)
+	// key[last] = 0 - not needed, because this is the default
+	return key
 }

x/bank/types/key_test.go

@@ -56,3 +56,15 @@ func TestAddressFromBalancesStore(t *testing.T) {
 		})
 	}
 }
+
+func TestCreateDenomAddressPrefix(t *testing.T) {
+	require := require.New(t)
+
+	key := types.CreateDenomAddressPrefix("")
+	require.Len(key, len(types.DenomAddressPrefix)+1)
+	require.Equal(append(types.DenomAddressPrefix, 0), key)
+
+	key = types.CreateDenomAddressPrefix("abc")
+	require.Len(key, len(types.DenomAddressPrefix)+4)
+	require.Equal(append(types.DenomAddressPrefix, 'a', 'b', 'c', 0), key)
+}