Address reviews

CHANGELOG.md

@@ -101,6 +101,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
   * Move Baseapp panic recovery into a middleware.
   * Rename simulation helper methods `baseapp.{Check,Deliver}` to `baseapp.Sim{Check,Deliver}**`.
 * (x/gov) [\#10373](https://github.com/cosmos/cosmos-sdk/pull/10373) Removed gov `keeper.{MustMarshal, MustUnmarshal}`.
+* [\#10348](https://github.com/cosmos/cosmos-sdk/pull/10348) StdSignBytes takes a new argument of type `*tx.Tip` for signing over tips using LEGACY_AMINO_JSON.
 
 
 ### Client Breaking Changes

x/auth/migrations/legacytx/stdtx_test.go

@@ -125,11 +125,6 @@ func TestStdSignBytes(t *testing.T) {
 			args{"1234", 3, 6, 0, StdFee{Amount: defaultFee.Amount, Gas: defaultFee.Gas, Payer: addr.String(), Granter: addr.String()}, []sdk.Msg{testdata.NewTestMsg(addr)}, "memo", nil},
 			fmt.Sprintf(`{"account_number":"3","chain_id":"1234","fee":{"amount":[{"amount":"150","denom":"atom"}],"gas":"100000","granter":"%s","payer":"%s"},"memo":"memo","msgs":[["%s"]],"sequence":"6"}`, addr, addr, addr),
 		},
-		{
-			"no tip (omitempty)",
-			args{"1234", 3, 6, 0, StdFee{Amount: defaultFee.Amount, Gas: defaultFee.Gas, Payer: addr.String()}, []sdk.Msg{testdata.NewTestMsg(addr)}, "memo", nil},
-			fmt.Sprintf(`{"account_number":"3","chain_id":"1234","fee":{"amount":[{"amount":"150","denom":"atom"}],"gas":"100000","payer":"%s"},"memo":"memo","msgs":[["%s"]],"sequence":"6"}`, addr, addr),
-		},
 		{
 			"no fee, with tip",
 			args{"1234", 3, 6, 0, StdFee{}, []sdk.Msg{testdata.NewTestMsg(addr)}, "memo", defaultTip},

x/auth/tx/legacy_amino_json_test.go

@@ -68,7 +68,7 @@ func TestLegacyAminoJSONHandler_GetSignBytes(t *testing.T) {
 			legacytx.StdSignBytes(chainId, accNum, seqNum, timeout, legacytx.StdFee{Amount: coins, Gas: gas, Granter: addr2.String()}, []sdk.Msg{msg}, memo, nil),
 		},
 		{
-			"explicit fee payer and feegranter", addr1.String(),
+			"explicit fee payer and fee granter", addr1.String(),
 			func(w *wrapper) {
 				w.SetFeePayer(addr2)
 				w.SetFeeGranter(addr2)
@@ -80,11 +80,6 @@ func TestLegacyAminoJSONHandler_GetSignBytes(t *testing.T) {
 			func(w *wrapper) { w.SetTip(tip) },
 			legacytx.StdSignBytes(chainId, accNum, seqNum, timeout, legacytx.StdFee{}, []sdk.Msg{msg}, memo, tip),
 		},
-		{
-			"signer which is not tipper", addr2.String(),
-			func(w *wrapper) { w.SetTip(tip) },
-			legacytx.StdSignBytes(chainId, accNum, seqNum, timeout, legacytx.StdFee{Amount: coins, Gas: gas}, []sdk.Msg{msg}, memo, tip),
-		},
 	}
 
 	handler := signModeLegacyAminoJSONHandler{}