fix(authz)!: prunning: unable to execute authorization

[aleem1314]

Description

Closes: #10611

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[atheeshp]

lgtm

[robert-zaremba]

We still need to be able to remove expired grants.

[robert-zaremba]

so why we don't want to clean authorization if it's expired?

[aleem1314]

Expired authorizations are not pruned from the state. see 8311#issuecomment.

[robert-zaremba]

Thanks. I totally forgot about that issue.

[robert-zaremba]

So, let's either decide here what shall we do with expired authorization or create a new issue.
CC: @cmwaters

[robert-zaremba]

One solution I have in mind is following:

• remove expired grants in begin blocker (same as we do with gov proposals). What do you think? @aaronc , @alexanderbez , @AmauryM ?

[robert-zaremba]

Let's decide if we really want to remove the grant pruning or fix it. I would prefer to fix it.

[robert-zaremba]

I'm blocking this PR only to clarify what we want to achieve, it's totally fine to schedule a next task and re-enable pruning, or do it here (to be honest, I think we should do it here, because this PR does only a temporal solutions).

[aleem1314]

@robert-zaremba let's merge this PR. I've raised a follow-up PR(#10714) for pruning expired authorizations.

[likhita-809]

lgtm

[robert-zaremba]

let's merge this PR. I've raised a follow-up PR(#10714) for pruning expired authorizations.

Why you didn't do that update here? This PR doesn't make much sense without #10714

[aleem1314]

Closing in favor of #10714