Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: tx with generate-only and offline shouldn't use chain id #10710

Merged
merged 12 commits into from
Dec 10, 2021
Merged

feat: tx with generate-only and offline shouldn't use chain id #10710

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a1d7baf
tx with generate-only and offline shouldn't use chain id
likhita-809 Dec 9, 2021
fbcb7da
add changelog
likhita-809 Dec 9, 2021
29e5106
add tests
likhita-809 Dec 9, 2021
3bd11f4
wip tests
likhita-809 Dec 9, 2021
ba78a27
remove logs
likhita-809 Dec 9, 2021
feeda6a
address review comment
likhita-809 Dec 9, 2021
1900140
Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into li…
likhita-809 Dec 9, 2021
eee0e89
Merge branch 'master' into likhita/fix-transactions
likhita-809 Dec 10, 2021
deaa127
Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into li…
likhita-809 Dec 10, 2021
818cbb2
Merge branch 'likhita/fix-transactions' of https://github.com/cosmos/…
likhita-809 Dec 10, 2021
75db253
Merge branch 'master' into likhita/fix-transactions
mergify[bot] Dec 10, 2021
97488cf
Merge branch 'master' into likhita/fix-transactions
mergify[bot] Dec 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add tests
  • Loading branch information
@likhita-809
likhita-809 committed Dec 9, 2021
commit 29e5106e05b929766c5fcd82e08d504d49cfcbbf
17 changes: 17 additions & 0 deletions x/bank/client/testutil/suite.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,6 +414,23 @@ func (s *IntegrationTestSuite) TestNewSendTxCmd() {
},
false, 0, &sdk.TxResponse{},
},
{
"chain-id shouldn't be used with offline and generate-only flags",
val.Address,
val.Address,
sdk.NewCoins(
sdk.NewCoin(fmt.Sprintf("%stoken", val.Moniker), sdk.NewInt(10)),
sdk.NewCoin(s.cfg.BondDenom, sdk.NewInt(10)),
),
[]string{
fmt.Sprintf("--%s=true", flags.FlagSkipConfirmation),
fmt.Sprintf("--%s=%s", flags.FlagBroadcastMode, flags.BroadcastSync),
fmt.Sprintf("--%s=%s", flags.FlagFees, sdk.NewCoins(sdk.NewCoin(s.cfg.BondDenom, sdk.NewInt(10))).String()),
fmt.Sprintf("--%s=true", flags.FlagOffline),
fmt.Sprintf("--%s=true", flags.FlagGenerateOnly),
},
false, 0, &sdk.TxResponse{},
},
{
"not enough fees",
val.Address,
Expand Down