Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Speedup cachekv iterator on large deletions & IBC v2 upgrade logic (backport #10741) #10746

Merged
merged 2 commits into from
Dec 13, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 12, 2021

This is an automatic backport of pull request #10741 done by Mergify.
Cherry-pick of 314e1d5 has failed:

On branch mergify/bp/release/v0.42.x/pr-10741
Your branch is up to date with 'origin/release/v0.42.x'.

You are currently cherry-picking commit 314e1d52c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   store/cachekv/memiterator.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md
	both modified:   store/cachekv/store_bench_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

…gic (#10741)

(cherry picked from commit 314e1d5)

# Conflicts:
#	CHANGELOG.md
#	store/cachekv/store_bench_test.go
@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #10746 (12dc5fa) into release/v0.42.x (01fac64) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           release/v0.42.x   #10746   +/-   ##
================================================
  Coverage            62.96%   62.96%           
================================================
  Files                  622      622           
  Lines                41343    41343           
================================================
  Hits                 26033    26033           
  Misses               12916    12916           
  Partials              2394     2394           
Impacted Files Coverage Δ
store/cachekv/memiterator.go 80.00% <100.00%> (ø)

@amaury1093 amaury1093 merged commit c81d3d6 into release/v0.42.x Dec 13, 2021
@amaury1093 amaury1093 deleted the mergify/bp/release/v0.42.x/pr-10741 branch December 13, 2021 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants