feat: add msg for permanent locked vesting accounts #11019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tac0turtle
approved these changes
Jan 25, 2022
amaury1093
approved these changes
Jan 25, 2022
| @@ -56,6 +56,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
| * [\#10507](https://github.com/cosmos/cosmos-sdk/pull/10507) Add middleware for tx priority. | |||
| * [\#10311](https://github.com/cosmos/cosmos-sdk/pull/10311) Adds cli to use tips transactions. It adds an `--aux` flag to all CLI tx commands to generate the aux signer data (with optional tip), and a new `tx aux-to-fee` subcommand to let the fee payer gather aux signer data and broadcast the tx | |||
| * [\#10430](https://github.com/cosmos/cosmos-sdk/pull/10430) ADR-040: Add store/v2 `MultiStore` implementation | |||
| * [\#11019](https://github.com/cosmos/cosmos-sdk/pull/11019) Add `MsgCreatePermanentLockedAccount` and CLI method for creating permanent locked account | |||
There was a problem hiding this comment.
We should also add a state-machine breaking one
anilcse
approved these changes
Jan 25, 2022
Codecov Report
@@ Coverage Diff @@
## master #11019 +/- ##
==========================================
+ Coverage 65.86% 65.89% +0.02%
==========================================
Files 644 677 +33
Lines 65630 68131 +2501
==========================================
+ Hits 43229 44895 +1666
- Misses 19920 20527 +607
- Partials 2481 2709 +228
|
robert-zaremba
approved these changes
Jan 25, 2022
Comment on lines
199
to
201
| if err != nil { | ||
| s.T().Fatalf("Getting initial latest height: %v", err) | ||
| } |
There was a problem hiding this comment.
Suggested change
| if err != nil { | |
| s.T().Fatalf("Getting initial latest height: %v", err) | |
| } | |
| s.Require().NoError(err, "Getting initial latest height") |
| next, err := s.network.WaitForHeight(height + 1) | ||
| if err != nil { | ||
| s.T().Fatalf("Waiting for height %d: %v", height+1, err) | ||
| } |
There was a problem hiding this comment.
as above, let's use require
x/auth/vesting/types/msgs.go
Outdated
| // ValidateBasic Implements Msg. | ||
| func (msg MsgCreatePermanentLockedAccount) ValidateBasic() error { | ||
| if _, err := sdk.AccAddressFromBech32(msg.FromAddress); err != nil { | ||
| return sdkerrors.Wrapf(sdkerrors.ErrInvalidAddress, "invalid sender address: %s", err) |
There was a problem hiding this comment.
Suggested change
| return sdkerrors.Wrapf(sdkerrors.ErrInvalidAddress, "invalid sender address: %s", err) | |
| return sdkerrors.ErrInvalidAddress.Wrapf("invalid sender address: %s", err) |
webmaster128
reviewed
Apr 7, 2022
| @@ -18,6 +18,8 @@ func RegisterLegacyAminoCodec(cdc *codec.LegacyAmino) { | |||
| cdc.RegisterConcrete(&DelayedVestingAccount{}, "cosmos-sdk/DelayedVestingAccount", nil) | |||
| cdc.RegisterConcrete(&PeriodicVestingAccount{}, "cosmos-sdk/PeriodicVestingAccount", nil) | |||
| cdc.RegisterConcrete(&PermanentLockedAccount{}, "cosmos-sdk/PermanentLockedAccount", nil) | |||
| cdc.RegisterConcrete(&MsgCreateVestingAccount{}, "cosmos-sdk/MsgCreateVestingAccount", nil) | |||
There was a problem hiding this comment.
Does this line mean there is no Amino JSON signing support for MsgCreateVestingAccount in 0.44 and 0.45?
There was a problem hiding this comment.
hmm, I think it would still work in 0.44 and 0.45, but be shown without the type and value fields, similarly to cosmos/cosmjs#1026 (comment)
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #11016
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change