Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix the broken links in the documents #11477

Merged
merged 3 commits into from
Mar 30, 2022
Merged

docs: Fix the broken links in the documents #11477

merged 3 commits into from
Mar 30, 2022

Conversation

houshengbo
Copy link

@houshengbo houshengbo commented Mar 28, 2022 •
edited
Loading

Description

Closes: #11476

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@houshengbo houshengbo changed the title doc: Fix the broken link for [dev calls] docs: Fix the broken link for [dev calls] Mar 28, 2022
amaury1093
amaury1093 approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@houshengbo houshengbo changed the title docs: Fix the broken link for [dev calls] docs: Fix the broken links in the documents Mar 28, 2022
@houshengbo
Copy link
Author

@AmauryM Thanks for the review.
I just added another commit to fix the broken link to ABCI spec as well.

@houshengbo houshengbo closed this Mar 28, 2022
@houshengbo houshengbo reopened this Mar 28, 2022
@likhita-809 likhita-809 added the A:automerge Automatically merge PR once all prerequisites pass. label Mar 30, 2022
@mergify mergify bot merged commit 74432f4 into cosmos:master Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaury1093 amaury1093 amaury1093 approved these changes

@atheeshp atheeshp atheeshp approved these changes

@likhita-809 likhita-809 likhita-809 approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

Assignees

@amaury1093 amaury1093

@atheeshp atheeshp

Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A broken link to the [dev calls] in the docs
4 participants
@houshengbo @amaury1093 @atheeshp @likhita-809