Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade the Cosmos-SDK to Go 1.18 #11663

Merged
merged 13 commits into from
Apr 19, 2022
Merged

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Apr 17, 2022

Description

This PR works towards the completion of the Go Workspaces issue #11450

It does the following:

  • Upgrades the Cosmos-SDK to Go v1.18
  • Changes the version of gogo/protobuf to v1.3.2, which exists upstream, unlike v1.3.3 everywhere possible. The use of the 1.3.3 version number and lack of an upstream version is the blocker for Go Workspaces.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added C:depinject Issues and PR related to depinject C:Cosmovisor Issues and PR related to Cosmovisor C:orm C:Rosetta Issues and PR related to Rosetta C:Store T: CI labels Apr 17, 2022
@codecov
Copy link

codecov bot commented Apr 17, 2022

Codecov Report

Merging #11663 (fe5daa6) into master (75d4e41) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

❗ Current head fe5daa6 differs from pull request most recent head 1ab778a. Consider uploading reports for the commit 1ab778a to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11663      +/-   ##
==========================================
- Coverage   65.84%   65.83%   -0.01%     
==========================================
  Files         667      667              
  Lines       70374    70374              
==========================================
- Hits        46336    46334       -2     
+ Misses      21347    21345       -2     
- Partials     2691     2695       +4     
Impacted Files Coverage Δ
x/group/keeper/msg_server.go 68.35% <66.66%> (ø)
x/group/keeper/invariants.go 53.62% <100.00%> (ø)
version/version.go 56.52% <0.00%> (-6.53%) ⬇️
crypto/keys/internal/ecdsa/privkey.go 84.21% <0.00%> (+1.75%) ⬆️

@faddat faddat changed the title Upgrade the Cosmos-SDK to Go 1.18 chore: Upgrade the Cosmos-SDK to Go 1.18 Apr 17, 2022
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

contrib/devtools/Dockerfile Show resolved Hide resolved
contrib/devtools/Dockerfile Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@faddat
Copy link
Contributor Author

faddat commented Apr 19, 2022

PS: The reason that I took the explicit versions out of the Dockerfiles is that if they are there, it is certain that:

  • They'll need to be updated in the future
  • we'll be using out of date builds of alpine

By not specifying the versions explicitly, we will always use the latest Go and alpine

@alexanderbez
Copy link
Contributor

@faddat there are two CI failures

@faddat
Copy link
Contributor Author

faddat commented Apr 19, 2022

I think it is super reasonable to mention:

#11688

@julienrbrt julienrbrt added the A:automerge Automatically merge PR once all prerequisites pass. label Apr 19, 2022
@mergify mergify bot merged commit 9bed633 into cosmos:master Apr 19, 2022
@alexanderbez alexanderbez mentioned this pull request Apr 20, 2022
19 tasks
@faddat faddat mentioned this pull request May 26, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Cosmovisor Issues and PR related to Cosmovisor C:depinject Issues and PR related to depinject C:orm C:Rosetta Issues and PR related to Rosetta C:Store T: CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants